Merge pull request ryanmcdermott#222 from filipetedim/patch-1

ryanmcdermott · web-flow · commit 025f7f933c7c · 2017-07-12T07:43:23.000-07:00
Fixed duplicate code
diff --git a/README.md b/README.md
@@ -439,23 +439,21 @@ function showEmployeeList(employees) {
   employees.forEach((employee) => {
     const expectedSalary = employee.calculateExpectedSalary();
     const experience = employee.getExperience();
+    
+    let data = {
+      expectedSalary,
+      experience
+    };
 
-    let portfolio;
     switch (employee.type) {
       case 'manager':
-        portfolio = employee.getMBAProjects();
+        data.portfolio = employee.getMBAProjects();
         break;
       case 'developer':
-        portfolio = employee.getGithubLink();
+        data.githubLink = employee.getGithubLink();
         break;
     }
 
-    const data = {
-      expectedSalary,
-      experience,
-      portfolio
-    };
-
     render(data);
   });
 }
