fixed ugly problem with itemChange method

florianlink · florianlink · commit 167999381eda · 2015-01-21T15:16:06.000Z
diff --git a/generator/shellimplgenerator.cpp b/generator/shellimplgenerator.cpp
@@ -174,6 +174,12 @@ void ShellImplGenerator::write(QTextStream &s, const AbstractMetaClass *meta_cla
         }
         s << "    if (result) { Py_DECREF(result); } " << endl;
         s << "    Py_DECREF(obj);" << endl;
+        // ugly hack, we don't support QGraphicsScene* nor QGraphicsItem* QVariants in PythonQt...
+        if (fun->name() == "itemChange" && fun->type()->isVariant()) {
+            s << "    if (change0 == QGraphicsItem::ItemParentChange || change0 == QGraphicsItem::ItemSceneChange) {\n";
+            s << "      returnValue = value1;\n";
+            s << "    } \n";
+        }
         if (hasReturnValue) {
           s << "    return returnValue;" << endl;
         }
diff --git a/generator/typesystem_webkit.xml b/generator/typesystem_webkit.xml
@@ -32,9 +32,13 @@
     </enum-type>
     <enum-type name="QWebPage::ErrorDomain"/>
     
-    <value-type name="QWebElementCollection"/>    
-    
-    <object-type name="QGraphicsWebView"/>    
+    <value-type name="QWebElementCollection"/>
+
+    <object-type name="QGraphicsWebView">
+      <extra-includes>
+        <include file-name="QGraphicsScene" location="global"/>
+      </extra-includes>
+      </object-type>
     <object-type name="QWebView">
     </object-type>
     <object-type name="QWebFrame">

Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,12 @@ void ShellImplGenerator::write(QTextStream &s, const AbstractMetaClass *meta_cla`
`174`	`174`	`}`
`175`	`175`	`s << " if (result) { Py_DECREF(result); } " << endl;`
`176`	`176`	`s << " Py_DECREF(obj);" << endl;`
	`177`	`+ // ugly hack, we don't support QGraphicsScene* nor QGraphicsItem* QVariants in PythonQt...`
	`178`	`+ if (fun->name() == "itemChange" && fun->type()->isVariant()) {`
	`179`	`+ s << " if (change0 == QGraphicsItem::ItemParentChange \|\| change0 == QGraphicsItem::ItemSceneChange) {\n";`
	`180`	`+ s << " returnValue = value1;\n";`
	`181`	`+ s << " } \n";`
	`182`	`+ }`
`177`	`183`	`if (hasReturnValue) {`
`178`	`184`	`s << " return returnValue;" << endl;`
`179`	`185`	`}`