Skip to content

Commit a07e23d

Browse files
committed
BAEL-4686: fixed review comments
1 parent 2f42035 commit a07e23d

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

core-java-modules/core-java-collections-maps-3/src/test/java/com/baeldung/map/concurrenthashmap/NullAllowInMapUnitTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
public class NullAllowInMapUnitTest {
1414

1515
@Test
16-
public void allowNullKey_In_HashMapBackedSynchronizedMap() {
16+
public void givenHashMapBackedSynchronizedMap_whenNullAsKey_thenNoError() {
1717
Map<String, Integer> map = Collections
1818
.synchronizedMap(new HashMap<String, Integer>());
1919
map.put(null, 1);
@@ -22,50 +22,50 @@ public void allowNullKey_In_HashMapBackedSynchronizedMap() {
2222

2323

2424
@Test(expected = NullPointerException.class)
25-
public void allowNullKey_In_TreeMapBackedSynchronizedMap() {
25+
public void givenTreeMapBackedSynchronizedMap_whenNullAsKey_thenException() {
2626
Map<String, Integer> map = Collections.synchronizedMap(new TreeMap<String, Integer>());
2727
map.put(null, 1);
2828
Assert.assertTrue(map.get(null).equals(1));
2929
}
3030

3131
@Test
32-
public void allowNullKey_In_LinkedHashMapBackedSynchronizedMap() {
32+
public void givenLinkedHashMapBackedSynchronizedMap_whenNullAsKey_thenNoError() {
3333
Map<String, Integer> map = Collections
3434
.synchronizedMap(new LinkedHashMap<String, Integer>());
3535
map.put(null, 1);
3636
Assert.assertTrue(map.get(null).equals(1));
3737
}
3838

3939
@Test(expected = NullPointerException.class)
40-
public void allowNullKey_In_ConcurrentHasMap() {
40+
public void givenConcurrentHasMap_whenNullAsKey_thenException() {
4141
Map<String, Integer> map = new ConcurrentHashMap<>();
4242
map.put(null, 1);
4343
}
4444

4545
@Test
46-
public void allowNullValue_In_HashMapBackedSynchronizedMap() {
46+
public void givenHashMapBackedSynchronizedMap_whenNullAsValue_thenNoError() {
4747
Map<String, Integer> map = Collections.synchronizedMap(new HashMap<String, Integer>());
4848
map.put("1", null);
4949
Assert.assertNull(map.get("1"));
5050
}
5151

5252
@Test
53-
public void allowNullValue_In_TreeMapBackedSynchronizedMap() {
53+
public void givenTreeMapBackedSynchronizedMap_whenNullAsValue_thenNoError() {
5454
Map<String, Integer> map = Collections.synchronizedMap(new TreeMap<String, Integer>());
5555
map.put("1", null);
5656
Assert.assertNull(map.get("1"));
5757
}
5858

5959
@Test
60-
public void allowNullValue_In_LinkedHashSynchronizedMap() {
60+
public void givenLinkedHashMapBackedSynchronizedMap_whenNullAsValue_thenNoError() {
6161
Map<String, Integer> map = Collections
6262
.synchronizedMap(new LinkedHashMap<String, Integer>());
6363
map.put("1", null);
6464
Assert.assertNull(map.get("1"));
6565
}
6666

6767
@Test(expected = NullPointerException.class)
68-
public void allowNullValue_In_ConcurrentHasMap() {
68+
public void givenConcurrentHasMap_whenNullAsValue_thenException() {
6969
Map<String, Integer> map = new ConcurrentHashMap<>();
7070
map.put("1", null);
7171
}

0 commit comments

Comments
 (0)