squid:S2974 - Classes without public constructors should be final

Mohammed Ezzat · Mohammed Ezzat · commit 632174b6dc5f · 2016-02-09T17:19:31.000+02:00
diff --git a/builder/src/main/java/com/iluwatar/builder/Hero.java b/builder/src/main/java/com/iluwatar/builder/Hero.java
@@ -27,7 +27,7 @@
  * Hero, the class with many parameters.
  * 
  */
-public class Hero {
+public final class Hero {
 
   private final Profession profession;
   private final String name;
diff --git a/caching/src/main/java/com/iluwatar/caching/AppManager.java b/caching/src/main/java/com/iluwatar/caching/AppManager.java
@@ -33,7 +33,7 @@
  * CacheStore class.
  *
  */
-public class AppManager {
+public final class AppManager {
 
   private static CachingPolicy cachingPolicy;
 
diff --git a/caching/src/main/java/com/iluwatar/caching/DbManager.java b/caching/src/main/java/com/iluwatar/caching/DbManager.java
@@ -43,7 +43,7 @@
  * during runtime (createVirtualDB()).</p>
  * 
  */
-public class DbManager {
+public final class DbManager {
 
   private static MongoClient mongoClient;
   private static MongoDatabase db;
diff --git a/flux/src/main/java/com/iluwatar/flux/dispatcher/Dispatcher.java b/flux/src/main/java/com/iluwatar/flux/dispatcher/Dispatcher.java
@@ -37,7 +37,7 @@
  * Dispatcher sends Actions to registered Stores.
  *
  */
-public class Dispatcher {
+public final class Dispatcher {
 
   private static Dispatcher instance = new Dispatcher();
 
diff --git a/multiton/src/main/java/com/iluwatar/multiton/Nazgul.java b/multiton/src/main/java/com/iluwatar/multiton/Nazgul.java
@@ -30,7 +30,7 @@
  * Nazgul is a Multiton class. Nazgul instances can be queried using {@link #getInstance} method.
  *
  */
-public class Nazgul {
+public final class Nazgul {
 
   private static Map<NazgulName, Nazgul> nazguls;
 
diff --git a/naked-objects/integtests/src/test/java/domainapp/integtests/bootstrap/SimpleAppSystemInitializer.java b/naked-objects/integtests/src/test/java/domainapp/integtests/bootstrap/SimpleAppSystemInitializer.java
@@ -19,7 +19,7 @@
 import org.apache.isis.objectstore.jdo.datanucleus.DataNucleusPersistenceMechanismInstaller;
 import org.apache.isis.objectstore.jdo.datanucleus.IsisConfigurationForJdoIntegTests;
 
-public class SimpleAppSystemInitializer {
+public final class SimpleAppSystemInitializer {
 
   private SimpleAppSystemInitializer() {
   }
diff --git a/null-object/src/main/java/com/iluwatar/nullobject/NullNode.java b/null-object/src/main/java/com/iluwatar/nullobject/NullNode.java
@@ -29,7 +29,7 @@
  * Implemented as Singleton, since all the NullNodes are the same.
  *
  */
-public class NullNode implements Node {
+public final class NullNode implements Node {
 
   private static NullNode instance = new NullNode();
 
diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/hibernate/HibernateUtil.java b/service-layer/src/main/java/com/iluwatar/servicelayer/hibernate/HibernateUtil.java
@@ -32,7 +32,7 @@
 /**
  * Produces the Hibernate {@link SessionFactory}.
  */
-public class HibernateUtil {
+public final class HibernateUtil {
 
   /**
    * The cached session factory
diff --git a/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceLocator.java b/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceLocator.java
@@ -28,7 +28,7 @@
  *
  * @author saifasif
  */
-public class ServiceLocator {
+public final class ServiceLocator {
 
   private static ServiceCache serviceCache = new ServiceCache();
 
diff --git a/singleton/src/main/java/com/iluwatar/singleton/InitializingOnDemandHolderIdiom.java b/singleton/src/main/java/com/iluwatar/singleton/InitializingOnDemandHolderIdiom.java
@@ -34,7 +34,7 @@
  *
  * @author mortezaadi@gmail.com
  */
-public class InitializingOnDemandHolderIdiom implements Serializable {
+public final class InitializingOnDemandHolderIdiom implements Serializable {
 
   private static final long serialVersionUID = 1L;
 
diff --git a/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLocking.java b/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLocking.java
@@ -31,7 +31,7 @@
  *
  * @author mortezaadi@gmail.com
  */
-public class ThreadSafeDoubleCheckLocking {
+public final class ThreadSafeDoubleCheckLocking {
 
   private static volatile ThreadSafeDoubleCheckLocking instance;
 
diff --git a/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java b/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java
@@ -29,7 +29,7 @@
  * Note: if created by reflection then a singleton will not be created but multiple options in the
  * same classloader
  */
-public class ThreadSafeLazyLoadedIvoryTower {
+public final class ThreadSafeLazyLoadedIvoryTower {
 
   private static ThreadSafeLazyLoadedIvoryTower instance = null;
 
diff --git a/step-builder/src/main/java/com/iluwatar/stepbuilder/CharacterStepBuilder.java b/step-builder/src/main/java/com/iluwatar/stepbuilder/CharacterStepBuilder.java
@@ -28,7 +28,7 @@
 /**
  * The Step Builder class.
  */
-public class CharacterStepBuilder {
+public final class CharacterStepBuilder {
 
   private CharacterStepBuilder() {}
 
diff --git a/tolerant-reader/src/main/java/com/iluwatar/tolerantreader/RainbowFishSerializer.java b/tolerant-reader/src/main/java/com/iluwatar/tolerantreader/RainbowFishSerializer.java
@@ -38,7 +38,7 @@
  * added to the schema.
  *
  */
-public class RainbowFishSerializer {
+public final class RainbowFishSerializer {
 
   private RainbowFishSerializer() {
   }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`* Hero, the class with many parameters.`
`28`	`28`	`*`
`29`	`29`	`*/`
`30`		`-public class Hero {`
	`30`	`+public final class Hero {`
`31`	`31`
`32`	`32`	`private final Profession profession;`
`33`	`33`	`private final String name;`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@`
`33`	`33`	`* CacheStore class.`
`34`	`34`	`*`
`35`	`35`	`*/`
`36`		`-public class AppManager {`
	`36`	`+public final class AppManager {`
`37`	`37`
`38`	`38`	`private static CachingPolicy cachingPolicy;`
`39`	`39`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@`
`43`	`43`	`* during runtime (createVirtualDB()).</p>`
`44`	`44`	`*`
`45`	`45`	`*/`
`46`		`-public class DbManager {`
	`46`	`+public final class DbManager {`
`47`	`47`
`48`	`48`	`private static MongoClient mongoClient;`
`49`	`49`	`private static MongoDatabase db;`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`* Dispatcher sends Actions to registered Stores.`
`38`	`38`	`*`
`39`	`39`	`*/`
`40`		`-public class Dispatcher {`
	`40`	`+public final class Dispatcher {`
`41`	`41`
`42`	`42`	`private static Dispatcher instance = new Dispatcher();`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`* Nazgul is a Multiton class. Nazgul instances can be queried using {@link #getInstance} method.`
`31`	`31`	`*`
`32`	`32`	`*/`
`33`		`-public class Nazgul {`
	`33`	`+public final class Nazgul {`
`34`	`34`
`35`	`35`	`private static Map<NazgulName, Nazgul> nazguls;`
`36`	`36`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`import org.apache.isis.objectstore.jdo.datanucleus.DataNucleusPersistenceMechanismInstaller;`
`20`	`20`	`import org.apache.isis.objectstore.jdo.datanucleus.IsisConfigurationForJdoIntegTests;`
`21`	`21`
`22`		`-public class SimpleAppSystemInitializer {`
	`22`	`+public final class SimpleAppSystemInitializer {`
`23`	`23`
`24`	`24`	`private SimpleAppSystemInitializer() {`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`* Implemented as Singleton, since all the NullNodes are the same.`
`30`	`30`	`*`
`31`	`31`	`*/`
`32`		`-public class NullNode implements Node {`
	`32`	`+public final class NullNode implements Node {`
`33`	`33`
`34`	`34`	`private static NullNode instance = new NullNode();`
`35`	`35`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@`
`28`	`28`	`*`
`29`	`29`	`* @author saifasif`
`30`	`30`	`*/`
`31`		`-public class ServiceLocator {`
	`31`	`+public final class ServiceLocator {`
`32`	`32`
`33`	`33`	`private static ServiceCache serviceCache = new ServiceCache();`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`	`*`
`35`	`35`	`* @author mortezaadi@gmail.com`
`36`	`36`	`*/`
`37`		`-public class InitializingOnDemandHolderIdiom implements Serializable {`
	`37`	`+public final class InitializingOnDemandHolderIdiom implements Serializable {`
`38`	`38`
`39`	`39`	`private static final long serialVersionUID = 1L;`
`40`	`40`