squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding

Mohammed Ezzat · Mohammed Ezzat · commit 046e13111991 · 2016-02-23T20:57:55.000+02:00
diff --git a/flux/src/main/java/com/iluwatar/flux/dispatcher/Dispatcher.java b/flux/src/main/java/com/iluwatar/flux/dispatcher/Dispatcher.java
@@ -71,6 +71,6 @@ public void menuItemSelected(MenuItem menuItem) {
   }
 
   private void dispatchAction(Action action) {
-    stores.stream().forEach((store) -> store.onAction(action));
+    stores.stream().forEach(store -> store.onAction(action));
   }
 }
diff --git a/flux/src/main/java/com/iluwatar/flux/store/Store.java b/flux/src/main/java/com/iluwatar/flux/store/Store.java
@@ -44,6 +44,6 @@ public void registerView(View view) {
   }
 
   protected void notifyChange() {
-    views.stream().forEach((view) -> view.storeChanged(this));
+    views.stream().forEach(view -> view.storeChanged(this));
   }
 }
diff --git a/half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/App.java b/half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/App.java
@@ -143,6 +143,6 @@ private static long ap(long i) {
     } catch (InterruptedException e) {
       System.out.println(e);
     }
-    return (i) * (i + 1) / 2;
+    return i * (i + 1) / 2;
   }
 }
diff --git a/layers/src/main/java/com/iluwatar/layers/CakeBakingServiceImpl.java b/layers/src/main/java/com/iluwatar/layers/CakeBakingServiceImpl.java
@@ -54,7 +54,7 @@ public CakeBakingServiceImpl() {
   public void bakeNewCake(CakeInfo cakeInfo) throws CakeBakingException {
     List<CakeTopping> allToppings = getAvailableToppingEntities();
     List<CakeTopping> matchingToppings =
-        allToppings.stream().filter((t) -> t.getName().equals(cakeInfo.cakeToppingInfo.name))
+        allToppings.stream().filter(t -> t.getName().equals(cakeInfo.cakeToppingInfo.name))
             .collect(Collectors.toList());
     if (matchingToppings.isEmpty()) {
       throw new CakeBakingException(String.format("Topping %s is not available",
@@ -64,7 +64,7 @@ public void bakeNewCake(CakeInfo cakeInfo) throws CakeBakingException {
     Set<CakeLayer> foundLayers = new HashSet<>();
     for (CakeLayerInfo info : cakeInfo.cakeLayerInfos) {
       Optional<CakeLayer> found =
-          allLayers.stream().filter((layer) -> layer.getName().equals(info.name)).findFirst();
+          allLayers.stream().filter(layer -> layer.getName().equals(info.name)).findFirst();
       if (!found.isPresent()) {
         throw new CakeBakingException(String.format("Layer %s is not available", info.name));
       } else {
diff --git a/layers/src/main/java/com/iluwatar/layers/CakeViewImpl.java b/layers/src/main/java/com/iluwatar/layers/CakeViewImpl.java
@@ -36,6 +36,6 @@ public CakeViewImpl(CakeBakingService cakeBakingService) {
   }
 
   public void render() {
-    cakeBakingService.getAllCakes().stream().forEach((cake) -> System.out.println(cake));
+    cakeBakingService.getAllCakes().stream().forEach(cake -> System.out.println(cake));
   }
 }
diff --git a/message-channel/src/main/java/com/iluwatar/message/channel/App.java b/message-channel/src/main/java/com/iluwatar/message/channel/App.java
@@ -66,7 +66,7 @@ public void configure() throws Exception {
     });
 
     context.start();
-    context.getRoutes().stream().forEach((r) -> System.out.println(r));
+    context.getRoutes().stream().forEach(r -> System.out.println(r));
     context.stop();
   }
 }
diff --git a/publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/App.java b/publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/App.java
@@ -61,7 +61,7 @@ public void configure() throws Exception {
     });
     ProducerTemplate template = context.createProducerTemplate();
     context.start();
-    context.getRoutes().stream().forEach((r) -> System.out.println(r));
+    context.getRoutes().stream().forEach(r -> System.out.println(r));
     template.sendBody("direct:origin", "Hello from origin");
     context.stop();
   }
diff --git a/reactor/src/main/java/com/iluwatar/reactor/app/LoggingHandler.java b/reactor/src/main/java/com/iluwatar/reactor/app/LoggingHandler.java
@@ -47,7 +47,7 @@ public void handleChannelRead(AbstractNioChannel channel, Object readObject, Sel
      * received is a ByteBuffer (from TCP channel) or a DatagramPacket (from UDP channel).
      */
     if (readObject instanceof ByteBuffer) {
-      doLogging(((ByteBuffer) readObject));
+      doLogging((ByteBuffer) readObject);
       sendReply(channel, key);
     } else if (readObject instanceof DatagramPacket) {
       DatagramPacket datagram = (DatagramPacket) readObject;
diff --git a/repository/src/main/java/com/iluwatar/repository/Person.java b/repository/src/main/java/com/iluwatar/repository/Person.java
@@ -97,9 +97,9 @@ public int hashCode() {
     final int prime = 31;
     int result = 1;
     result = prime * result + age;
-    result = prime * result + ((id == null) ? 0 : id.hashCode());
-    result = prime * result + ((name == null) ? 0 : name.hashCode());
-    result = prime * result + ((surname == null) ? 0 : surname.hashCode());
+    result = prime * result + (id == null ? 0 : id.hashCode());
+    result = prime * result + (name == null ? 0 : name.hashCode());
+    result = prime * result + (surname == null ? 0 : surname.hashCode());
     return result;
   }
 
diff --git a/step-builder/src/main/java/com/iluwatar/stepbuilder/Character.java b/step-builder/src/main/java/com/iluwatar/stepbuilder/Character.java
@@ -97,7 +97,7 @@ public String toString() {
             .append(name)
             .append(" armed with a ")
             .append(weapon != null ? weapon : spell != null ? spell : "with nothing")
-            .append(abilities != null ? (" and wielding " + abilities + " abilities") : "")
+            .append(abilities != null ? " and wielding " + abilities + " abilities" : "")
             .append('.');
     return sb.toString();
   }

Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,6 @@ public void menuItemSelected(MenuItem menuItem) {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`private void dispatchAction(Action action) {`
`74`		`- stores.stream().forEach((store) -> store.onAction(action));`
	`74`	`+ stores.stream().forEach(store -> store.onAction(action));`
`75`	`75`	`}`
`76`	`76`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,6 @@ public void registerView(View view) {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`protected void notifyChange() {`
`47`		`- views.stream().forEach((view) -> view.storeChanged(this));`
	`47`	`+ views.stream().forEach(view -> view.storeChanged(this));`
`48`	`48`	`}`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -143,6 +143,6 @@ private static long ap(long i) {`
`143`	`143`	`} catch (InterruptedException e) {`
`144`	`144`	`System.out.println(e);`
`145`	`145`	`}`
`146`		`- return (i) * (i + 1) / 2;`
	`146`	`+ return i * (i + 1) / 2;`
`147`	`147`	`}`
`148`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,6 @@ public CakeViewImpl(CakeBakingService cakeBakingService) {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public void render() {`
`39`		`- cakeBakingService.getAllCakes().stream().forEach((cake) -> System.out.println(cake));`
	`39`	`+ cakeBakingService.getAllCakes().stream().forEach(cake -> System.out.println(cake));`
`40`	`40`	`}`
`41`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public void configure() throws Exception {`
`66`	`66`	`});`
`67`	`67`
`68`	`68`	`context.start();`
`69`		`- context.getRoutes().stream().forEach((r) -> System.out.println(r));`
	`69`	`+ context.getRoutes().stream().forEach(r -> System.out.println(r));`
`70`	`70`	`context.stop();`
`71`	`71`	`}`
`72`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public void configure() throws Exception {`
`61`	`61`	`});`
`62`	`62`	`ProducerTemplate template = context.createProducerTemplate();`
`63`	`63`	`context.start();`
`64`		`- context.getRoutes().stream().forEach((r) -> System.out.println(r));`
	`64`	`+ context.getRoutes().stream().forEach(r -> System.out.println(r));`
`65`	`65`	`template.sendBody("direct:origin", "Hello from origin");`
`66`	`66`	`context.stop();`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ public String toString() {`
`97`	`97`	`.append(name)`
`98`	`98`	`.append(" armed with a ")`
`99`	`99`	`.append(weapon != null ? weapon : spell != null ? spell : "with nothing")`
`100`		`- .append(abilities != null ? (" and wielding " + abilities + " abilities") : "")`
	`100`	`+ .append(abilities != null ? " and wielding " + abilities + " abilities" : "")`
`101`	`101`	`.append('.');`
`102`	`102`	`return sb.toString();`
`103`	`103`	`}`