Tests should use separate shelve test database

andela-cdike · andela-cdike · commit 17dac42139a0 · 2017-08-27T20:34:09.000+01:00
- Switch from depreccated yield_fixture to fixture decorator
diff --git a/19-dyn-attr-prop/oscon/test_schedule1.py b/19-dyn-attr-prop/oscon/test_schedule1.py
@@ -1,15 +1,20 @@
+import os
 import shelve
+
 import pytest
 
 import schedule1 as schedule
 
+DB_NAME = 'data/test_db'
+
 
-@pytest.yield_fixture
+@pytest.fixture(scope='module')
 def db():
-    with shelve.open(schedule.DB_NAME) as the_db:
+    with shelve.open(DB_NAME) as the_db:
         if schedule.CONFERENCE not in the_db:
             schedule.load_db(the_db)
         yield the_db
+        os.remove(DB_NAME)
 
 
 def test_record_class():
diff --git a/19-dyn-attr-prop/oscon/test_schedule2.py b/19-dyn-attr-prop/oscon/test_schedule2.py
@@ -1,15 +1,18 @@
+import os
 import shelve
+
 import pytest
 
 import schedule2 as schedule
 
 
-@pytest.yield_fixture
+@pytest.fixture(scope='module')
 def db():
-    with shelve.open(schedule.DB_NAME) as the_db:
+    with shelve.open(DB_NAME) as the_db:
         if schedule.CONFERENCE not in the_db:
             schedule.load_db(the_db)
         yield the_db
+        os.remove(DB_NAME)
 
 
 def test_record_attr_access():
