lib: turn on strict mode

bnoordhuis · bnoordhuis · commit 21130c7d6fca · 2014-11-22T17:23:30.000+01:00
Turn on strict mode for the files in the lib/ directory. It helps catch bugs and can have a positive effect on performance. PR-URL: node-forward/node#64 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
diff --git a/lib/_debug_agent.js b/lib/_debug_agent.js
@@ -1,3 +1,5 @@
+'use strict';
+
 var assert = require('assert');
 var net = require('net');
 var util = require('util');
diff --git a/lib/_debugger.js b/lib/_debugger.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var util = require('util'),
     path = require('path'),
     net = require('net'),
diff --git a/lib/_http_agent.js b/lib/_http_agent.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var net = require('net');
 var util = require('util');
 var EventEmitter = require('events').EventEmitter;
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var util = require('util');
 var net = require('net');
 var url = require('url');
diff --git a/lib/_http_common.js b/lib/_http_common.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var FreeList = require('freelist').FreeList;
 var HTTPParser = process.binding('http_parser').HTTPParser;
 
diff --git a/lib/_http_incoming.js b/lib/_http_incoming.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var util = require('util');
 var Stream = require('stream');
 
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var assert = require('assert').ok;
 var Stream = require('stream');
 var timers = require('timers');
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var util = require('util');
 var net = require('net');
 var EventEmitter = require('events').EventEmitter;
diff --git a/lib/_linklist.js b/lib/_linklist.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 function init(list) {
   list._idleNext = list;
   list._idlePrev = list;
diff --git a/lib/_stream_duplex.js b/lib/_stream_duplex.js
@@ -24,6 +24,8 @@
 // prototypally inherits from Readable, and then parasitically from
 // Writable.
 
+'use strict';
+
 module.exports = Duplex;
 var util = require('util');
 var Readable = require('_stream_readable');
diff --git a/lib/_stream_passthrough.js b/lib/_stream_passthrough.js
@@ -23,6 +23,8 @@
 // basically just the most minimal sort of Transform stream.
 // Every written chunk gets output as-is.
 
+'use strict';
+
 module.exports = PassThrough;
 
 var Transform = require('_stream_transform');
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 module.exports = Readable;
 Readable.ReadableState = ReadableState;
 
diff --git a/lib/_stream_transform.js b/lib/_stream_transform.js
@@ -62,6 +62,8 @@
 // would be consumed, and then the rest would wait (un-transformed) until
 // the results of the previous transformed chunk were consumed.
 
+'use strict';
+
 module.exports = Transform;
 
 var Duplex = require('_stream_duplex');
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js
@@ -23,6 +23,8 @@
 // Implement an async ._write(chunk, cb), and it'll handle all
 // the drain event emission and buffering.
 
+'use strict';
+
 module.exports = Writable;
 Writable.WritableState = WritableState;
 
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var util = require('util');
 var constants = require('constants');
 var tls = require('tls');
diff --git a/lib/_tls_legacy.js b/lib/_tls_legacy.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var assert = require('assert');
 var events = require('events');
 var stream = require('stream');
@@ -444,9 +446,9 @@ CryptoStream.prototype.destroySoon = function(err) {
     // was written on this side was read from the other side.
     var self = this;
     var waiting = 1;
-    function finish() {
+    var finish = function() {
       if (--waiting === 0) self.destroy();
-    }
+    };
     this._opposite.once('end', finish);
     if (!this._finished) {
       this.once('finish', finish);
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -22,6 +22,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var assert = require('assert');
 var crypto = require('crypto');
 var net = require('net');
diff --git a/lib/assert.js b/lib/assert.js
@@ -22,6 +22,8 @@
 // ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 // WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 // UTILITY
 var util = require('util');
 var pSlice = Array.prototype.slice;
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var buffer = process.binding('buffer');
 var smalloc = process.binding('smalloc');
 var util = require('util');
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var StringDecoder = require('string_decoder').StringDecoder;
 var EventEmitter = require('events').EventEmitter;
 var net = require('net');
diff --git a/lib/cluster.js b/lib/cluster.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var EventEmitter = require('events').EventEmitter;
 var assert = require('assert');
 var dgram = require('dgram');
@@ -680,8 +682,6 @@ function sendHelper(proc, message, handle, cb) {
 // to the callback but intercepts and redirects ACK messages.
 function internal(worker, cb) {
   return function(message, handle) {
-    'use strict';
-
     if (message.cmd !== 'NODE_CLUSTER') return;
     var fn = cb;
     if (!util.isUndefined(message.ack)) {
diff --git a/lib/console.js b/lib/console.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var util = require('util');
 
 function Console(stdout, stderr) {
@@ -89,13 +91,13 @@ Console.prototype.timeEnd = function(label) {
 };
 
 
-Console.prototype.trace = function() {
+Console.prototype.trace = function trace() {
   // TODO probably can to do this better with V8's debug object once that is
   // exposed.
   var err = new Error;
   err.name = 'Trace';
   err.message = util.format.apply(this, arguments);
-  Error.captureStackTrace(err, arguments.callee);
+  Error.captureStackTrace(err, trace);
   this.error(err.stack);
 };
 
diff --git a/lib/constants.js b/lib/constants.js
@@ -19,4 +19,6 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 module.exports = process.binding('constants');
diff --git a/lib/crypto.js b/lib/crypto.js
@@ -22,6 +22,8 @@
 // Note: In 0.8 and before, crypto functions all defaulted to using
 // binary-encoded strings rather than buffers.
 
+'use strict';
+
 exports.DEFAULT_ENCODING = 'buffer';
 
 try {
@@ -600,11 +602,11 @@ function pbkdf2(password, salt, iterations, keylen, digest, callback) {
   // at this point, we need to handle encodings.
   var encoding = exports.DEFAULT_ENCODING;
   if (callback) {
-    function next(er, ret) {
+    var next = function(er, ret) {
       if (ret)
         ret = ret.toString(encoding);
       callback(er, ret);
-    }
+    };
     binding.PBKDF2(password, salt, iterations, keylen, digest, next);
   } else {
     var ret = binding.PBKDF2(password, salt, iterations, keylen, digest);
diff --git a/lib/dgram.js b/lib/dgram.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var assert = require('assert');
 var util = require('util');
 var events = require('events');
diff --git a/lib/dns.js b/lib/dns.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var net = require('net');
 var util = require('util');
 
diff --git a/lib/domain.js b/lib/domain.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var util = require('util');
 var EventEmitter = require('events');
 var inherits = util.inherits;
diff --git a/lib/events.js b/lib/events.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var domain;
 var util = require('util');
 
diff --git a/lib/freelist.js b/lib/freelist.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 // This is a free list to avoid creating so many of the same object.
 exports.FreeList = function(name, max, constructor) {
   this.name = name;
diff --git a/lib/fs.js b/lib/fs.js
@@ -25,6 +25,8 @@
 //
 //   var mode = 438; /* mode=0666 */
 
+'use strict';
+
 var util = require('util');
 var pathModule = require('path');
 
diff --git a/lib/http.js b/lib/http.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var util = require('util');
 var EventEmitter = require('events').EventEmitter;
 
diff --git a/lib/https.js b/lib/https.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var tls = require('tls');
 var url = require('url');
 var http = require('http');
diff --git a/lib/module.js b/lib/module.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var NativeModule = require('native_module');
 var util = NativeModule.require('util');
 var runInThisContext = require('vm').runInThisContext;
diff --git a/lib/net.js b/lib/net.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var events = require('events');
 var stream = require('stream');
 var timers = require('timers');
@@ -612,7 +614,6 @@ Socket.prototype.__defineGetter__('localPort', function() {
 
 
 Socket.prototype.write = function(chunk, encoding, cb) {
-  'use strict';
   if (!util.isString(chunk) && !util.isBuffer(chunk))
     throw new TypeError('invalid data');
   return stream.Duplex.prototype.write.apply(this, arguments);
diff --git a/lib/os.js b/lib/os.js
@@ -19,6 +19,8 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
+
 var binding = process.binding('os');
 var util = require('util');
 var isWindows = process.platform === 'win32';
diff --git a/lib/path.js b/lib/path.js
@@ -19,6 +19,7 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+'use strict';
 
 var isWindows = process.platform === 'win32';
 var util = require('util');
diff --git a/lib/querystring.js b/lib/querystring.js
@@ -21,6 +21,8 @@
 
 // Query String Utilities
 
+'use strict';
+
 var QueryString = exports;
 var util = require('util');
 
diff --git a/lib/readline.js b/lib/readline.js
@@ -25,6 +25,8 @@
 // * http://invisible-island.net/xterm/ctlseqs/ctlseqs.html
 // * http://www.3waylabs.com/nw/WWW/products/wizcon/vt220.html
 
+'use strict';
+
 var kHistorySize = 30;
 
 var util = require('util');
diff --git a/lib/repl.js b/lib/repl.js
diff --git a/lib/smalloc.js b/lib/smalloc.js
diff --git a/lib/stream.js b/lib/stream.js
diff --git a/lib/string_decoder.js b/lib/string_decoder.js
diff --git a/lib/sys.js b/lib/sys.js
diff --git a/lib/timers.js b/lib/timers.js
diff --git a/lib/tls.js b/lib/tls.js
diff --git a/lib/tracing.js b/lib/tracing.js
diff --git a/lib/tty.js b/lib/tty.js
diff --git a/lib/url.js b/lib/url.js
diff --git a/lib/util.js b/lib/util.js
diff --git a/lib/vm.js b/lib/vm.js
diff --git a/lib/zlib.js b/lib/zlib.js
diff --git a/src/node.js b/src/node.js

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+'use strict';`
	`2`	`+`
`1`	`3`	`var assert = require('assert');`
`2`	`4`	`var net = require('net');`
`3`	`5`	`var util = require('util');`