Suppress irrelevant ErrorProne warnings

olim7t · olim7t · commit 9ec5ee641956 · 2018-01-24T11:12:31.000-08:00
diff --git a/core/src/main/java/com/datastax/oss/driver/api/core/cql/Bindable.java b/core/src/main/java/com/datastax/oss/driver/api/core/cql/Bindable.java
@@ -31,6 +31,7 @@ public interface Bindable<T extends Bindable<T>>
    *
    * @throws IndexOutOfBoundsException if the index is invalid.
    */
+  @SuppressWarnings("ReferenceEquality")
   default boolean isSet(int i) {
     return getBytesUnsafe(i) != ProtocolConstants.UNSET_VALUE;
   }
@@ -43,6 +44,7 @@ default boolean isSet(int i) {
    *
    * @throws IndexOutOfBoundsException if the id is invalid.
    */
+  @SuppressWarnings("ReferenceEquality")
   default boolean isSet(CqlIdentifier id) {
     return getBytesUnsafe(id) != ProtocolConstants.UNSET_VALUE;
   }
@@ -55,6 +57,7 @@ default boolean isSet(CqlIdentifier id) {
    *
    * @throws IndexOutOfBoundsException if the name is invalid.
    */
+  @SuppressWarnings("ReferenceEquality")
   default boolean isSet(String name) {
     return getBytesUnsafe(name) != ProtocolConstants.UNSET_VALUE;
   }
diff --git a/core/src/main/java/com/datastax/oss/driver/internal/core/channel/StreamIdGenerator.java b/core/src/main/java/com/datastax/oss/driver/internal/core/channel/StreamIdGenerator.java
@@ -37,6 +37,7 @@ class StreamIdGenerator {
     this.availableIds = this.maxAvailableIds;
   }
 
+  @SuppressWarnings("NonAtomicVolatileUpdate") // see explanation in class Javadoc
   int acquire() {
     int id = ids.nextClearBit(0);
     if (id >= maxAvailableIds) {
@@ -47,6 +48,7 @@ int acquire() {
     return id;
   }
 
+  @SuppressWarnings("NonAtomicVolatileUpdate")
   void release(int id) {
     if (ids.get(id)) {
       availableIds++;
diff --git a/core/src/main/java/com/datastax/oss/driver/internal/core/metadata/NodeStateManager.java b/core/src/main/java/com/datastax/oss/driver/internal/core/metadata/NodeStateManager.java
@@ -115,6 +115,8 @@ private void markInitialized() {
       isInitialized = true;
     }
 
+    // Updates to DefaultNode's volatile fields are confined to the admin thread
+    @SuppressWarnings("NonAtomicVolatileUpdate")
     private void onChannelEvent(ChannelEvent event) {
       assert adminExecutor.inEventLoop();
       if (closeWasCalled) {
diff --git a/core/src/main/java/com/datastax/oss/driver/internal/core/util/concurrent/UncaughtExceptions.java b/core/src/main/java/com/datastax/oss/driver/internal/core/util/concurrent/UncaughtExceptions.java
@@ -50,6 +50,7 @@ public static <T> void log(Future<T> future) {
     }
   }
 
+  @SuppressWarnings("TypeParameterUnusedInFormals") // type parameter is only needed for chaining
   public static <T> T log(Throwable t) {
     Loggers.warnWithException(LOG, "Uncaught exception in scheduled task", t);
     return null;
diff --git a/core/src/test/java/com/datastax/oss/driver/internal/SerializationHelper.java b/core/src/test/java/com/datastax/oss/driver/internal/SerializationHelper.java
@@ -36,6 +36,8 @@ public static <T> byte[] serialize(T t) {
     }
   }
 
+  // the calling code performs validations on the result, so this doesn't matter
+  @SuppressWarnings("TypeParameterUnusedInFormals")
   public static <T> T deserialize(byte[] bytes) {
     try {
       ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(bytes));
diff --git a/core/src/test/java/com/datastax/oss/driver/internal/core/util/concurrent/ScheduledTaskCapturingEventLoop.java b/core/src/test/java/com/datastax/oss/driver/internal/core/util/concurrent/ScheduledTaskCapturingEventLoop.java
@@ -41,6 +41,7 @@
  *
  * <p>This is used to make unit tests independent of time.
  */
+@SuppressWarnings("FunctionalInterfaceClash") // does not matter for test code
 public class ScheduledTaskCapturingEventLoop extends DefaultEventLoop {
 
   private final BlockingQueue<CapturedTask> capturedTasks = new ArrayBlockingQueue<>(100);
diff --git a/test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/cluster/SessionUtils.java b/test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/cluster/SessionUtils.java
@@ -96,17 +96,19 @@ public static String getConfigPath() {
    * in the 0th DC of the provided Cassandra resource as contact points, and the default
    * configuration augmented with the provided options.
    */
+  @SuppressWarnings("TypeParameterUnusedInFormals")
   public static <SessionT extends Session> SessionT newSession(
       CassandraResourceRule cassandraResource, String... options) {
     return newSession(cassandraResource, null, new NodeStateListener[0], options);
   }
 
+  @SuppressWarnings("TypeParameterUnusedInFormals")
   public static <SessionT extends Session> SessionT newSession(
       CassandraResourceRule cassandraResource, CqlIdentifier keyspace, String... options) {
     return newSession(cassandraResource, keyspace, new NodeStateListener[0], options);
   }
 
-  @SuppressWarnings("unchecked")
+  @SuppressWarnings({"unchecked", "TypeParameterUnusedInFormals"})
   public static <SessionT extends Session> SessionT newSession(
       CassandraResourceRule cassandraResource,
       CqlIdentifier keyspace,

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public interface Bindable<T extends Bindable<T>>`
`31`	`31`	`*`
`32`	`32`	`* @throws IndexOutOfBoundsException if the index is invalid.`
`33`	`33`	`*/`
	`34`	`+ @SuppressWarnings("ReferenceEquality")`
`34`	`35`	`default boolean isSet(int i) {`
`35`	`36`	`return getBytesUnsafe(i) != ProtocolConstants.UNSET_VALUE;`
`36`	`37`	`}`
`@@ -43,6 +44,7 @@ default boolean isSet(int i) {`
`43`	`44`	`*`
`44`	`45`	`* @throws IndexOutOfBoundsException if the id is invalid.`
`45`	`46`	`*/`
	`47`	`+ @SuppressWarnings("ReferenceEquality")`
`46`	`48`	`default boolean isSet(CqlIdentifier id) {`
`47`	`49`	`return getBytesUnsafe(id) != ProtocolConstants.UNSET_VALUE;`
`48`	`50`	`}`
`@@ -55,6 +57,7 @@ default boolean isSet(CqlIdentifier id) {`
`55`	`57`	`*`
`56`	`58`	`* @throws IndexOutOfBoundsException if the name is invalid.`
`57`	`59`	`*/`
	`60`	`+ @SuppressWarnings("ReferenceEquality")`
`58`	`61`	`default boolean isSet(String name) {`
`59`	`62`	`return getBytesUnsafe(name) != ProtocolConstants.UNSET_VALUE;`
`60`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ class StreamIdGenerator {`
`37`	`37`	`this.availableIds = this.maxAvailableIds;`
`38`	`38`	`}`
`39`	`39`
	`40`	`+ @SuppressWarnings("NonAtomicVolatileUpdate") // see explanation in class Javadoc`
`40`	`41`	`int acquire() {`
`41`	`42`	`int id = ids.nextClearBit(0);`
`42`	`43`	`if (id >= maxAvailableIds) {`
`@@ -47,6 +48,7 @@ int acquire() {`
`47`	`48`	`return id;`
`48`	`49`	`}`
`49`	`50`
	`51`	`+ @SuppressWarnings("NonAtomicVolatileUpdate")`
`50`	`52`	`void release(int id) {`
`51`	`53`	`if (ids.get(id)) {`
`52`	`54`	`availableIds++;`
Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,8 @@ private void markInitialized() {`
`115`	`115`	`isInitialized = true;`
`116`	`116`	`}`
`117`	`117`
	`118`	`+ // Updates to DefaultNode's volatile fields are confined to the admin thread`
	`119`	`+ @SuppressWarnings("NonAtomicVolatileUpdate")`
`118`	`120`	`private void onChannelEvent(ChannelEvent event) {`
`119`	`121`	`assert adminExecutor.inEventLoop();`
`120`	`122`	`if (closeWasCalled) {`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ public static <T> void log(Future<T> future) {`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ @SuppressWarnings("TypeParameterUnusedInFormals") // type parameter is only needed for chaining`
`53`	`54`	`public static <T> T log(Throwable t) {`
`54`	`55`	`Loggers.warnWithException(LOG, "Uncaught exception in scheduled task", t);`
`55`	`56`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,8 @@ public static <T> byte[] serialize(T t) {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
	`39`	`+ // the calling code performs validations on the result, so this doesn't matter`
	`40`	`+ @SuppressWarnings("TypeParameterUnusedInFormals")`
`39`	`41`	`public static <T> T deserialize(byte[] bytes) {`
`40`	`42`	`try {`
`41`	`43`	`ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(bytes));`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@`
`41`	`41`	`*`
`42`	`42`	`* <p>This is used to make unit tests independent of time.`
`43`	`43`	`*/`
	`44`	`+@SuppressWarnings("FunctionalInterfaceClash") // does not matter for test code`
`44`	`45`	`public class ScheduledTaskCapturingEventLoop extends DefaultEventLoop {`
`45`	`46`
`46`	`47`	`private final BlockingQueue<CapturedTask> capturedTasks = new ArrayBlockingQueue<>(100);`