http2: rename function for clarity

BridgeAR · BridgeAR · commit 92db780d9e39 · 2019-03-27T17:05:17.000+01:00
The function does not only validate the input but it causes side effects by adding default options to the input object in case the option is not set. PR-URL: nodejs#26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -607,7 +607,7 @@ function requestOnConnect(headers, options) {
 // 4. if specified, options.silent must be a boolean
 //
 // Also sets the default priority options if they are not set.
-const validatePriorityOptions = hideStackFrames((options) => {
+const setAndValidatePriorityOptions = hideStackFrames((options) => {
   if (options.weight === undefined) {
     options.weight = NGHTTP2_DEFAULT_WEIGHT;
   } else if (typeof options.weight !== 'number') {
@@ -1451,7 +1451,7 @@ class ClientHttp2Session extends Http2Session {
         throw new ERR_HTTP2_CONNECT_PATH();
     }
 
-    validatePriorityOptions(options);
+    setAndValidatePriorityOptions(options);
 
     if (options.endStream === undefined) {
       // For some methods, we know that a payload is meaningless, so end the
@@ -1839,7 +1839,7 @@ class Http2Stream extends Duplex {
 
     assertIsObject(options, 'options');
     options = { ...options };
-    validatePriorityOptions(options);
+    setAndValidatePriorityOptions(options);
 
     const priorityFn = submitPriority.bind(this, options);
 
