errors: alter ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED

davidmarkclements · BridgeAR · commit 926a8a616b11 · 2018-05-01T15:49:04.000+02:00
changes the base instance for ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED from Error to TypeError as a more accurate representation of the error.. PR-URL: nodejs#19958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -596,10 +596,8 @@ E('ERR_HTTP2_PAYLOAD_FORBIDDEN',
   'Responses with %s status must not have a payload', Error);
 E('ERR_HTTP2_PING_CANCEL', 'HTTP2 ping cancelled', Error);
 E('ERR_HTTP2_PING_LENGTH', 'HTTP2 ping payload must be 8 bytes', RangeError);
-
-// This should probably be a `TypeError`.
 E('ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED',
-  'Cannot set HTTP/2 pseudo-headers', Error);
+  'Cannot set HTTP/2 pseudo-headers', TypeError);
 E('ERR_HTTP2_PUSH_DISABLED', 'HTTP/2 client has disabled push streams', Error);
 E('ERR_HTTP2_SEND_FILE', 'Only regular files can be sent', Error);
 E('ERR_HTTP2_SESSION_ERROR', 'Session closed with error code %s', Error);
diff --git a/test/parallel/test-http2-compat-serverresponse-headers.js b/test/parallel/test-http2-compat-serverresponse-headers.js
@@ -76,7 +76,7 @@ server.listen(0, common.mustCall(function() {
       () => response.setHeader(header, 'foobar'),
       {
         code: 'ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED',
-        type: Error,
+        type: TypeError,
         message: 'Cannot set HTTP/2 pseudo-headers'
       })
     );

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ server.listen(0, common.mustCall(function() {`
`76`	`76`	`() => response.setHeader(header, 'foobar'),`
`77`	`77`	`{`
`78`	`78`	`code: 'ERR_HTTP2_PSEUDOHEADER_NOT_ALLOWED',`
`79`		`- type: Error,`
	`79`	`+ type: TypeError,`
`80`	`80`	`message: 'Cannot set HTTP/2 pseudo-headers'`
`81`	`81`	`})`
`82`	`82`	`);`