fixed thrown TypeErrors on mac, while scrolling over the top edge

Konstantin · Konstantin · commit c67cc4e883a3 · 2013-10-30T15:16:51.000+01:00
Due to the mac specific possibility to scroll above the top viewport edges (this nice viewport pull effect), you get some negative scroll and offset values. This causes a call of this.names[-1] which throws a TypeError. So we just test for a positive scroll value to prevent this.
diff --git a/site/javascript/garden.js b/site/javascript/garden.js
@@ -33,7 +33,7 @@ Sections.prototype = {
             articleID = this.names[this.names.length - 1].id;
 
         for(var i = 0, l = this.names.length; i < l; i++) {
-            if (this.names[i].offset > scroll) {
+            if (scroll > 0 && this.names[i].offset > scroll) {
                 articleID = this.names[i - 1].id;
                 break;
             }

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ Sections.prototype = {`
`33`	`33`	`articleID = this.names[this.names.length - 1].id;`
`34`	`34`
`35`	`35`	`for(var i = 0, l = this.names.length; i < l; i++) {`
`36`		`- if (this.names[i].offset > scroll) {`
	`36`	`+ if (scroll > 0 && this.names[i].offset > scroll) {`
`37`	`37`	`articleID = this.names[i - 1].id;`
`38`	`38`	`break;`
`39`	`39`	`}`