remove ToBitArray from interface

jaredvonhalle · jaredvonhalle · commit fe51d5be118f · 2016-08-17T10:18:37.000-05:00
diff --git a/Source/IBitset.cs b/Source/IBitset.cs
@@ -63,13 +63,6 @@ public interface IBitset : IEnumerable, System.Runtime.Serialization.ISerializab
         /// <returns>a new IBitSet</returns>
         IBitset Difference(IBitset otherSet);
 
-        /// <summary>
-        /// Returns the contents of this set as a bit array where the value is
-        /// set to true for each index that is a member of this set
-        /// </summary>
-        /// <returns>a new BitArray</returns>
-        BitArray ToBitArray();
-
         bool Equals(object obj);
 
         /// <summary>
diff --git a/Source/RoaringBitset.cs b/Source/RoaringBitset.cs
@@ -740,10 +740,5 @@ public void DifferenceWith(IBitset otherSet)
             }
             
         }
-
-        public BitArray ToBitArray()
-        {
-            throw new NotImplementedException();
-        }
     }
 }
diff --git a/Tests/BaseBitSetTests.cs b/Tests/BaseBitSetTests.cs
@@ -216,38 +216,6 @@ public virtual void DifferenceTest()
             Assert.AreEqual(true, mixedDiffSet2.Get(4));
         }
 
-        [TestMethod]
-        public virtual void ToBitArrayTest()
-        {
-            int[] set = SetGenerator.GetRandomArray(TEST_SET_LENGTH);
-            BitArray setArray = new BitArray(TEST_SET_LENGTH);
-
-            foreach (int index in set)
-            {
-                setArray[index] = true;
-            }
-
-            IBitset testSet = CreateSetFromIndices(set, TEST_SET_LENGTH);
-            BitArray testArray = testSet.ToBitArray();
-
-            bool expected = true;
-            bool actual = true;
-
-            for (int i = 0; i < setArray.Length; i++)
-            {
-                if (setArray[i])
-                {
-                    actual &= setArray[i] == testArray[i];
-                }
-                else
-                {
-                    //do nothing
-                }
-            }
-
-            Assert.AreEqual(expected, actual);
-        }
-
         [TestMethod]
         public virtual void CardinalityTest()
         {
diff --git a/Tests/RLEBitsetTests.cs b/Tests/RLEBitsetTests.cs
@@ -1,5 +1,6 @@
 ﻿using Microsoft.VisualStudio.TestTools.UnitTesting;
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;
@@ -34,5 +35,38 @@ public virtual void SerializationTest()
             Assert.AreEqual(actual, expected);
         }
 
+        [TestMethod()]
+        public virtual void ToBitArrayTest()
+        {
+            int TEST_SET_LENGTH = 10;
+            int[] set = SetGenerator.GetRandomArray(TEST_SET_LENGTH);
+            BitArray setArray = new BitArray(TEST_SET_LENGTH);
+
+            foreach (int index in set)
+            {
+                setArray[index] = true;
+            }
+
+            RLEBitset testSet = (RLEBitset)CreateSetFromIndices(set, TEST_SET_LENGTH);
+            BitArray testArray = testSet.ToBitArray();
+
+            bool expected = true;
+            bool actual = true;
+
+            for (int i = 0; i < setArray.Length; i++)
+            {
+                if (setArray[i])
+                {
+                    actual &= setArray[i] == testArray[i];
+                }
+                else
+                {
+                    //do nothing
+                }
+            }
+
+            Assert.AreEqual(expected, actual);
+        }
+
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -740,10 +740,5 @@ public void DifferenceWith(IBitset otherSet)`
`740`	`740`	`}`
`741`	`741`
`742`	`742`	`}`
`743`		`-`
`744`		`- public BitArray ToBitArray()`
`745`		`- {`
`746`		`- throw new NotImplementedException();`
`747`		`- }`
`748`	`743`	`}`
`749`	`744`	`}`