fix(statics): reject duplicate contract address and NFT index keys in coinmap#8966
Draft
nvjsr wants to merge 1 commit into
Draft
fix(statics): reject duplicate contract address and NFT index keys in coinmap#8966nvjsr wants to merge 1 commit into
nvjsr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: CGD-715
This pull request introduces stricter checks and error handling for duplicate contract addresses and NFT collection IDs when registering tokens in the coin map. It ensures that two tokens cannot be registered with the same contract address or NFT collection ID for the same network, preventing subtle bugs and improving the reliability of token management. The changes also include new error types, updates to the core logic in
CoinMap, and expanded test coverage.Error handling and validation improvements:
DuplicateContractAddressDefinitionErrorandDuplicateNftCollectionIdDefinitionErrorto provide clear error messages when a duplicate contract address or NFT collection ID is detected during token registration.CoinMapclass to check for and throw these errors inaddCoinif a token with the same contract address or NFT collection ID already exists for the same network. [1] [2]CoinMap(contractAddressKey,nftCollectionIdKey, andhasTokenAddressConflict) to centralize and simplify collision detection logic.Token registration and deduplication:
createTokenMapUsingConfigDetailsto skip adding tokens that would conflict with an existing contract address, preventing runtime errors during map creation.CoinMap.Test coverage:
Other updates:
erc7984Tokens.tsto use unique values.