feat(sdk-core): add execMode support to txrequests API#8952
Draft
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Draft
feat(sdk-core): add execMode support to txrequests API#8952bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Add optional execMode parameter to prebuildTxWithIntent and the
wallet prebuildTransaction flow. When set to 'EXEC_UNSPECIFIED',
the server defers transaction execution, giving Figure Markets
exchange control over the workflow. Defaults to 'EXEC_TRY' when
omitted (existing behavior is unchanged).
The field is passed as a top-level body param alongside intent,
apiVersion, and preview in the POST /wallet/{id}/txrequests call.
Ticket: CSHLD-972
Session-Id: caa99360-6177-4227-8aba-5043f8cb453f
Task-Id: 49710c31-924d-41fb-b44b-2dc4a10bce34
c22cdd0 to
edb5547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execModeparameter ('EXEC_TRY' | 'EXEC_UNSPECIFIED') toPrebuildTransactionWithIntentOptionsandPrebuildTransactionOptionsexecModeas a top-level body field inPOST /api/v2/wallet/{walletId}/txrequestsalongsideintent,apiVersion, andpreviewexecModethrough all transaction types inwallet.tsprebuildTransactionTxRequestsexecModetoBuildParamsso it passes throughprebuildWhitelistedParamsTxRequestExecModetype from@bitgo/sdk-coreWhen
execMode: 'EXEC_UNSPECIFIED'is set, the server defers transaction execution, giving Figure Markets exchange control over the workflow (e.g. forcontractCallintents). Omitting the field preserves existing behavior (EXEC_TRY).Test plan
modules/bitgo/test/v2/unit/internal/tssUtils/eddsa.ts:execMode: 'EXEC_UNSPECIFIED'is included in the request body when specifiedexecModeis absent from the request body when not specifiedyarn unit-test --scope bitgo -- -- --grep 'prebuildTxWithIntent'Ticket: CSHLD-972
🤖 Generated with Ralph