From 077d2de7e477a2563b64b7d9be2fb7d4a594949b Mon Sep 17 00:00:00 2001
From: Darius Parvin <dariusparvin@bitgo.com>
Date: Mon, 7 Mar 2022 16:03:12 -0800
Subject: [PATCH] feat: enable external signer mode for production

remove the restriction that allowed the external signer to be used only in a test env

Ticket: BG-43925
---
 modules/express/src/expressApp.ts         |  4 ----
 modules/express/test/unit/bitgoExpress.ts | 27 -----------------------
 2 files changed, 31 deletions(-)

diff --git a/modules/express/src/expressApp.ts b/modules/express/src/expressApp.ts
index 1367ab2f93..bbecfb18c1 100644
--- a/modules/express/src/expressApp.ts
+++ b/modules/express/src/expressApp.ts
@@ -217,10 +217,6 @@ function checkPreconditions(config: Config) {
     config.env = 'custom';
   }
 
-  if (env !== 'test' && (externalSignerUrl !== undefined || signerMode !== undefined)) {
-    throw new ExternalSignerConfigError('external signer feature is only enabled for test mode.');
-  }
-
   if (externalSignerUrl !== undefined && (signerMode !== undefined || signerFileSystemPath !== undefined)) {
     throw new ExternalSignerConfigError(
       'signerMode or signerFileSystemPath is set, but externalSignerUrl is also set.'
diff --git a/modules/express/test/unit/bitgoExpress.ts b/modules/express/test/unit/bitgoExpress.ts
index f5418a87d0..1f66ede829 100644
--- a/modules/express/test/unit/bitgoExpress.ts
+++ b/modules/express/test/unit/bitgoExpress.ts
@@ -464,32 +464,5 @@ describe('Bitgo Express', function () {
       (() => expressApp(args)).should.not.throw();
       readValidStub.restore();
     });
-
-    it('should require express to be in test mode when using the external signer feature', function () {
-      const readValidStub = sinon.stub(fs, 'readFileSync').returns(validPrvJSON);
-
-      const args: any = {
-        env: 'notTestMode',
-        signerMode: 'signerMode',
-        signerFileSystemPath: 'signerFileSystemPath',
-      };
-      (() => expressApp(args)).should.throw({
-        name: 'ExternalSignerConfigError',
-        message: 'external signer feature is only enabled for test mode.'
-      });
-
-      args.signerMode = undefined;
-      args.signerFileSystemPath = undefined;
-      args.externalSignerUrl = 'externalSignerUrl';
-      (() => expressApp(args)).should.throw({
-        name: 'ExternalSignerConfigError',
-        message: 'external signer feature is only enabled for test mode.'
-      });
-
-      args.env = 'test';
-      (() => expressApp(args)).should.not.throw();
-
-      readValidStub.restore();
-    });
   });
 });