Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lava/matplotlib-cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Bidibulke/matplotlib-cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 9 files changed
  • 2 contributors

Commits on Mar 26, 2020

  1. BLD adding some tests & ENH new functions in wrapper 

    TST
* adding some unit tests using Catch2 framework
* 6 test cases with 91 assertions.
* normally there is a test for each function in matplotlibcpp.h
* `class Plot` is not tested

MISC

According to numpy documentation:
* BLD change related to building and installing (examples, module, …)
* ENH enhancement
* TST addition or modification of tests
* ...
    @Bidibulke
    Bidibulke committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    771b7ed View commit details
    Browse the repository at this point in the history

  2. Squashed commit of the following: 

    commit 9047863bb0c1a34bc6473c2dadee720073db631e
Author: Claire Guilbaud <claire.guilbaud@cea.fr>
Date:   Thu Mar 26 15:46:34 2020 +0100

    @enh figure with variadic template args

commit a8a3dd018c14a5e5c98b084f566865ba936c4fec
Author: Claire Guilbaud <claire.guilbaud@cea.fr>
Date:   Thu Mar 26 14:55:36 2020 +0100

    @enh close

commit 6440609657de0f47b6fd4c1a8c213704f2810a4f
Author: Claire Guilbaud <claire.guilbaud@cea.fr>
Date:   Thu Mar 26 13:41:18 2020 +0100

    @enh generic form for scatter
    @Bidibulke
    Bidibulke committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    ff55d61 View commit details
    Browse the repository at this point in the history

  3. ENH use variadic templates args in scatter and figure 

    In order to avoid adding other declaration function for the same functionnality with other arguments, I had the possibility to pass extra-arguments in a tuple of variadic templates.

This enhancement could also be use to pass C++ objects such as vector, double
    @Bidibulke
    Bidibulke committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    690c733 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. @Maint fix some typos / add ioff function 

    also translate french comments
    @Bidibulke
    Bidibulke committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    62cf24e View commit details
    Browse the repository at this point in the history

  2. remove interpreter initialization in add_site and append_sys_path

    @Bidibulke
    Bidibulke committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    3723771 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Merge branch 'master' into master

    @Bidibulke
    Bidibulke authored Jun 2, 2020
    Configuration menu
    Copy the full SHA
    07a0f0d View commit details
    Browse the repository at this point in the history
Loading