scripts/docker-run.sh: fix wrong uid in warning 1001 -> 1000

marc-hb · lgirdwood · commit c28400baaa38 · 2022-10-10T11:29:05.000+01:00
Fixes commit d09844a ("zephyr/docker-build.sh: match UID with 'adduser' instead of 'chgrp -R'") Also clarify comment and add reference to new sudo-cwd.sh script. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
diff --git a/scripts/docker-run.sh b/scripts/docker-run.sh
@@ -25,10 +25,12 @@ if tty --quiet; then
     SOF_DOCKER_RUN="$SOF_DOCKER_RUN --tty"
 fi
 
-# Not fatal, just a warning to allow other "creative" solutions.
-# TODO: fix this with 'adduser' like in zephyr/docker-build.sh
-test "$(id -u)" = 1001 ||
-    >&2 printf "Warning: this script should be run as user ID 1001 to match the container\n"
+# The --user option below can cause the command to run as a user who
+# does not exist in the container. So far so good but in case something
+# ever goes wrong try replacing --user with the newer
+# scripts/sudo-cwd.sh script.
+test "$(id -u)" = 1000 ||
+  >&2 printf "Warning: this script should be run as user ID 1000 to match the container's account\n"
 
 set -x
 docker run -i -v "${SOF_TOP}":/home/sof/work/sof.git \
