Cocktail Shaker Sort | Code wasn't returning sorted Items. Changed that.

marsonya · marsonya · commit ac488fe6267e · 2020-11-02T15:25:59.000+05:30
diff --git a/Sorts/CocktailShakerSort.js b/Sorts/CocktailShakerSort.js
@@ -10,7 +10,6 @@
  */
 function cocktailShakerSort (items) {
   for (let i = items.length - 1; i > 0; i--) {
-    let swapped = false
     let j
 
     // Backwards
@@ -28,10 +27,9 @@ function cocktailShakerSort (items) {
         swapped = true
       }
     }
-    if (!swapped) {
-      return
-    }
   }
+
+  return items
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@`
`10`	`10`	`*/`
`11`	`11`	`function cocktailShakerSort (items) {`
`12`	`12`	`for (let i = items.length - 1; i > 0; i--) {`
`13`		`- let swapped = false`
`14`	`13`	`let j`
`15`	`14`
`16`	`15`	`// Backwards`
`@@ -28,10 +27,9 @@ function cocktailShakerSort (items) {`
`28`	`27`	`swapped = true`
`29`	`28`	`}`
`30`	`29`	`}`
`31`		`- if (!swapped) {`
`32`		`- return`
`33`		`- }`
`34`	`30`	`}`
	`31`	`+`
	`32`	`+ return items`
`35`	`33`	`}`
`36`	`34`
`37`	`35`	`/**`