Effect#noop allows custom parametricity

jnape · jnape · commit 44e7f2220cdc · 2019-05-16T18:00:01.000-05:00
diff --git a/src/main/java/com/jnape/palatable/lambda/functions/Effect.java b/src/main/java/com/jnape/palatable/lambda/functions/Effect.java
@@ -97,7 +97,7 @@ static <A> Effect<A> fromConsumer(Consumer<A> consumer) {
      * @param sideEffect the {@link SideEffect}
      * @return the {@link Effect}
      */
-    static Effect<Unit> effect(SideEffect sideEffect) {
+    static <A> Effect<A> effect(SideEffect sideEffect) {
         return effect(constantly(io(sideEffect)));
     }
 
@@ -108,7 +108,7 @@ static Effect<Unit> effect(SideEffect sideEffect) {
      */
     @SuppressWarnings("unused")
     static <A> Effect<A> noop() {
-        return effect(NOOP).contraMap(constantly(UNIT));
+        return effect(NOOP);
     }
 
     /**
diff --git a/src/test/java/com/jnape/palatable/lambda/functions/EffectTest.java b/src/test/java/com/jnape/palatable/lambda/functions/EffectTest.java
@@ -9,7 +9,6 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Consumer;
 
-import static com.jnape.palatable.lambda.adt.Unit.UNIT;
 import static com.jnape.palatable.lambda.functions.Effect.effect;
 import static com.jnape.palatable.lambda.functions.Effect.fromConsumer;
 import static com.jnape.palatable.lambda.functions.builtin.fn1.Constantly.constantly;
@@ -51,8 +50,8 @@ public void andThen() {
     public void staticFactoryMethods() {
         AtomicInteger counter = new AtomicInteger();
 
-        Effect<Unit> runnableEffect = effect(counter::incrementAndGet);
-        runnableEffect.apply(UNIT).unsafePerformIO();
+        Effect<String> sideEffect = effect(counter::incrementAndGet);
+        sideEffect.apply("foo").unsafePerformIO();
         assertEquals(1, counter.get());
 
         Effect<AtomicInteger> fnEffect = Effect.fromConsumer(AtomicInteger::incrementAndGet);
