Issue 893 (iluwatar#1014)

hbothra15 · iluwatar · commit cdb80b8ddd09 · 2019-10-30T08:27:24.000+02:00
* Using static object to reduce memory foot prints

* Updating README along with name of static fields

* Updating code as per review comments

* Updating code as per review comments

* Updating doc as per new code
diff --git a/factory-method/README.md b/factory-method/README.md
@@ -42,13 +42,13 @@ public interface Blacksmith {
 
 public class ElfBlacksmith implements Blacksmith {
   public Weapon manufactureWeapon(WeaponType weaponType) {
-    return new ElfWeapon(weaponType);
+    return ELFARSENAL.get(weaponType);
   }
 }
 
 public class OrcBlacksmith implements Blacksmith {
   public Weapon manufactureWeapon(WeaponType weaponType) {
-    return new OrcWeapon(weaponType);
+    return ORCARSENAL.get(weaponType);
   }
 }
 ```
diff --git a/factory-method/src/main/java/com/iluwatar/factory/method/ElfBlacksmith.java b/factory-method/src/main/java/com/iluwatar/factory/method/ElfBlacksmith.java
@@ -23,16 +23,27 @@
 
 package com.iluwatar.factory.method;
 
+import java.util.HashMap;
+import java.util.Map;
+
 /**
  * 
  * Concrete subclass for creating new objects.
  * 
  */
 public class ElfBlacksmith implements Blacksmith {
 
+  private static Map<WeaponType, ElfWeapon> ELFARSENAL;
+  static {
+	ELFARSENAL= new HashMap<>(WeaponType.values().length);
+	for (WeaponType type : WeaponType.values()) {
+		ELFARSENAL.put(type, new ElfWeapon(type));
+	}
+  }
+  
   @Override
   public Weapon manufactureWeapon(WeaponType weaponType) {
-    return new ElfWeapon(weaponType);
+    return ELFARSENAL.get(weaponType);
   }
-
+  
 }
diff --git a/factory-method/src/main/java/com/iluwatar/factory/method/OrcBlacksmith.java b/factory-method/src/main/java/com/iluwatar/factory/method/OrcBlacksmith.java
@@ -23,15 +23,26 @@
 
 package com.iluwatar.factory.method;
 
+import java.util.HashMap;
+import java.util.Map;
+
 /**
  * 
  * Concrete subclass for creating new objects.
  * 
  */
 public class OrcBlacksmith implements Blacksmith {
 
+  private static Map<WeaponType, OrcWeapon> ORCARSENAL;
+  static {
+    ORCARSENAL= new HashMap<>(WeaponType.values().length);
+	for (WeaponType type : WeaponType.values()) {
+	  ORCARSENAL.put(type, new OrcWeapon(type));
+	}
+  }
+  
   @Override
   public Weapon manufactureWeapon(WeaponType weaponType) {
-    return new OrcWeapon(weaponType);
+    return ORCARSENAL.get(weaponType);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -42,13 +42,13 @@ public interface Blacksmith {`
`42`	`42`
`43`	`43`	`public class ElfBlacksmith implements Blacksmith {`
`44`	`44`	`public Weapon manufactureWeapon(WeaponType weaponType) {`
`45`		`- return new ElfWeapon(weaponType);`
	`45`	`+ return ELFARSENAL.get(weaponType);`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`public class OrcBlacksmith implements Blacksmith {`
`50`	`50`	`public Weapon manufactureWeapon(WeaponType weaponType) {`
`51`		`- return new OrcWeapon(weaponType);`
	`51`	`+ return ORCARSENAL.get(weaponType);`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`	```