iluwatar#631 - Partial Response : Return video details as json string.

Gopinath Langote · Gopinath Langote · commit a0c081f5eabc · 2017-09-14T19:27:46.000+05:30
diff --git a/partial-response/src/main/java/com/iluwatar/partialresponse/Video.java b/partial-response/src/main/java/com/iluwatar/partialresponse/Video.java
@@ -29,7 +29,7 @@
  * <p>
  */
 public class Video {
-  private String id;
+  private Integer id;
   private String title;
   private Integer length;
   private String description;
@@ -41,10 +41,10 @@ public class Video {
    * @param title       video title
    * @param length      video length in minutes
    * @param description video description by publisher
-   * @param director   video director name
-   * @param language      video language {private, public}
+   * @param director    video director name
+   * @param language    video language {private, public}
    */
-  public Video(String id, String title, Integer length, String description, String director, String language) {
+  public Video(Integer id, String title, Integer length, String description, String director, String language) {
     this.id = id;
     this.title = title;
     this.length = length;
@@ -55,13 +55,12 @@ public Video(String id, String title, Integer length, String description, String
 
   @Override
   public String toString() {
-    return "Video{" +
-        "id='" + id + '\'' +
-        ", title='" + title + '\'' +
-        ", length=" + length +
-        ", description='" + description + '\'' +
-        ", director='" + director + '\'' +
-        ", language='" + language + '\'' +
-        '}';
+    return "{" +
+        "\"id\": \"" + id + "\"," +
+        "\"title\": \"" + title + "\"," +
+        "\"description\": \"" + description + "\"," +
+        "\"director\": \"" + director + "\"," +
+        "\"language\": \"" + language + "\"," +
+        "}";
   }
 }
diff --git a/partial-response/src/main/java/com/iluwatar/partialresponse/VideoResource.java b/partial-response/src/main/java/com/iluwatar/partialresponse/VideoResource.java
@@ -27,13 +27,13 @@
 import java.util.Map;
 
 public class VideoResource {
-  private Map<String, Video> videos;
+  private Map<Integer, Video> videos;
 
-  public VideoResource(Map<String, Video> videos) {
+  public VideoResource(Map<Integer, Video> videos) {
     this.videos = videos;
   }
 
-  public String getDetails(String id) {
+  public String getDetails(Integer id) {
     return videos.get(id).toString();
   }
 }
diff --git a/partial-response/src/test/java/com/iluwatar/partialresponse/VideoResourceTest.java b/partial-response/src/test/java/com/iluwatar/partialresponse/VideoResourceTest.java
@@ -30,21 +30,25 @@
 import java.util.HashMap;
 import java.util.Map;
 
+import static org.junit.Assert.assertEquals;
+
 public class VideoResourceTest {
   private VideoResource resource;
 
   @Before
   public void setUp() {
-    Map<String, Video> videos = new HashMap<>();
-    videos.put("1", new Video("1", "Avatar", 178, "epic science fiction film", "James Cameron", "English"));
-    videos.put("1", new Video("2", "Godzilla Resurgence", 120, "Action & drama movie|", "Hideaki Anno", "Japanese"));
-    videos.put("1", new Video("3", "Interstellar", 169, "Adventure & Sci-Fi", "Christopher Nolan", "English"));
+    Map<Integer, Video> videos = new HashMap<>();
+    videos.put(1, new Video(1, "Avatar", 178, "epic science fiction film", "James Cameron", "English"));
+    videos.put(2, new Video(2, "Godzilla Resurgence", 120, "Action & drama movie|", "Hideaki Anno", "Japanese"));
+    videos.put(3, new Video(3, "Interstellar", 169, "Adventure & Sci-Fi", "Christopher Nolan", "English"));
     resource = new VideoResource(videos);
   }
 
   @Test
   public void shouldGiveVideoDetailsById() {
-    String details = resource.getDetails("1");
-    System.out.println(details);
+    String details = resource.getDetails(1);
+
+    String expectedDetails = "{\"id\": \"1\",\"title\": \"Avatar\",\"description\": \"epic science fiction film\",\"director\": \"James Cameron\",\"language\": \"English\",}";
+    assertEquals(details, expectedDetails);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -27,13 +27,13 @@`
`27`	`27`	`import java.util.Map;`
`28`	`28`
`29`	`29`	`public class VideoResource {`
`30`		`- private Map<String, Video> videos;`
	`30`	`+ private Map<Integer, Video> videos;`
`31`	`31`
`32`		`- public VideoResource(Map<String, Video> videos) {`
	`32`	`+ public VideoResource(Map<Integer, Video> videos) {`
`33`	`33`	`this.videos = videos;`
`34`	`34`	`}`
`35`	`35`
`36`		`- public String getDetails(String id) {`
	`36`	`+ public String getDetails(Integer id) {`
`37`	`37`	`return videos.get(id).toString();`
`38`	`38`	`}`
`39`	`39`	`}`