Merge branch 'master' of https://github.com/iluwatar/java-design-patterns

adkm · adkm · commit 04dd93f8bc81 · 2017-10-15T18:45:36.000+02:00
diff --git a/balking/README.md b/balking/README.md
@@ -18,10 +18,10 @@ incomplete or inappropriate state
 ## Applicability
 Use the Balking pattern when
 
-*you want to invoke an action on an object only when it is in a particular state
-*objects are generally only in a state that is prone to balking temporarily
+* you want to invoke an action on an object only when it is in a particular state
+* objects are generally only in a state that is prone to balking temporarily
 but for an unknown amount of time
 
 ## Related patterns
 * Guarded Suspension Pattern
-* Double Checked Locking Pattern
+* Double Checked Locking Pattern
diff --git a/factory-method/src/test/java/com/iluwatar/factory/method/FactoryMethodTest.java b/factory-method/src/test/java/com/iluwatar/factory/method/FactoryMethodTest.java
@@ -95,7 +95,7 @@ public void testElfBlacksmithWithSpear() {
    */
   private void verifyWeapon(Weapon weapon, WeaponType expectedWeaponType, Class<?> clazz) {
     assertTrue("Weapon must be an object of: " + clazz.getName(), clazz.isInstance(weapon));
-    assertEquals("Weapon must be of weaponType: " + clazz.getName(), expectedWeaponType,
+    assertEquals("Weapon must be of weaponType: " + expectedWeaponType, expectedWeaponType,
         weapon.getWeaponType());
   }
 }
diff --git a/prototype/src/test/java/com/iluwatar/prototype/PrototypeTest.java b/prototype/src/test/java/com/iluwatar/prototype/PrototypeTest.java
@@ -56,7 +56,7 @@ public static Collection<Object[]> data() {
   /**
    * The tested prototype instance
    */
-  private final Prototype testedPrototype;
+  private final P testedPrototype;
 
   /**
    * The expected {@link Prototype#toString()} value
@@ -69,7 +69,7 @@ public static Collection<Object[]> data() {
    * @param testedPrototype  The tested prototype instance
    * @param expectedToString The expected {@link Prototype#toString()} value
    */
-  public PrototypeTest(final Prototype testedPrototype, final String expectedToString) {
+  public PrototypeTest(final P testedPrototype, final String expectedToString) {
     this.expectedToString = expectedToString;
     this.testedPrototype = testedPrototype;
   }
diff --git a/throttling/src/main/java/com/iluwatar/throttling/B2BService.java b/throttling/src/main/java/com/iluwatar/throttling/B2BService.java
@@ -46,7 +46,7 @@ public B2BService(Throttler timer) {
    */
   public int dummyCustomerApi(Tenant tenant) {
     String tenantName = tenant.getName();
-    int count = CallsCount.getCount(tenantName);
+    long count = CallsCount.getCount(tenantName);
     LOGGER.debug("Counter for {} : {} ", tenant.getName(), count);
     if (count >= tenant.getAllowedCallsPerSecond()) {
       LOGGER.error("API access per second limit reached for: {}", tenantName);
diff --git a/throttling/src/main/java/com/iluwatar/throttling/CallsCount.java b/throttling/src/main/java/com/iluwatar/throttling/CallsCount.java
@@ -22,51 +22,56 @@
  */
 package com.iluwatar.throttling;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.atomic.AtomicLong;
 
 /**
  * A class to keep track of the counter of different Tenants
  * @author drastogi
  *
  */
 public final class CallsCount {
-  private static Map<String, Integer> tenantCallsCount = new ConcurrentHashMap<>();
+
+  private static final Logger LOGGER = LoggerFactory.getLogger(CallsCount.class);
+  private static Map<String, AtomicLong> tenantCallsCount = new ConcurrentHashMap<>();
 
   /**
    * Add a new tenant to the map.
    * @param tenantName name of the tenant.
    */
   public static void addTenant(String tenantName) {
-    if (!tenantCallsCount.containsKey(tenantName)) {
-      tenantCallsCount.put(tenantName, 0);
-    }
+    tenantCallsCount.putIfAbsent(tenantName, new AtomicLong(0));
   }
   
   /**
    * Increment the count of the specified tenant.
    * @param tenantName name of the tenant.
    */
   public static void incrementCount(String tenantName) {
-    tenantCallsCount.put(tenantName, tenantCallsCount.get(tenantName) + 1);
+    tenantCallsCount.get(tenantName).incrementAndGet();
   }
   
   /**
    * 
    * @param tenantName name of the tenant.
    * @return the count of the tenant.
    */
-  public static int getCount(String tenantName) {
-    return tenantCallsCount.get(tenantName);
+  public static long getCount(String tenantName) {
+    return tenantCallsCount.get(tenantName).get();
   }
   
   /**
    * Resets the count of all the tenants in the map.
    */
   public static void reset() {
-    for (Entry<String, Integer> e : tenantCallsCount.entrySet()) {
-      tenantCallsCount.put(e.getKey(), 0);
+    LOGGER.debug("Resetting the map.");
+    for (Entry<String, AtomicLong> e : tenantCallsCount.entrySet()) {
+      tenantCallsCount.put(e.getKey(), new AtomicLong(0));
     }
   }
 }
diff --git a/throttling/src/test/java/com/iluwatar/throttling/B2BServiceTest.java b/throttling/src/test/java/com/iluwatar/throttling/B2BServiceTest.java
@@ -36,14 +36,13 @@ public class B2BServiceTest {
   @Test
   public void dummyCustomerApiTest() {
     Tenant tenant = new Tenant("testTenant", 2);
-    Throttler timer = new ThrottleTimerImpl(10);
+    Throttler timer = new ThrottleTimerImpl(100);
     B2BService service = new B2BService(timer);
-    
+
     for (int i = 0; i < 5; i++) {
       service.dummyCustomerApi(tenant);
     }
-    
-    int counter = CallsCount.getCount(tenant.getName());
+    long counter = CallsCount.getCount(tenant.getName());
     Assert.assertTrue("Counter limit must be reached", counter == 2);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ public void testElfBlacksmithWithSpear() {`
`95`	`95`	`*/`
`96`	`96`	`private void verifyWeapon(Weapon weapon, WeaponType expectedWeaponType, Class<?> clazz) {`
`97`	`97`	`assertTrue("Weapon must be an object of: " + clazz.getName(), clazz.isInstance(weapon));`
`98`		`- assertEquals("Weapon must be of weaponType: " + clazz.getName(), expectedWeaponType,`
	`98`	`+ assertEquals("Weapon must be of weaponType: " + expectedWeaponType, expectedWeaponType,`
`99`	`99`	`weapon.getWeaponType());`
`100`	`100`	`}`
`101`	`101`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,14 +36,13 @@ public class B2BServiceTest {`
`36`	`36`	`@Test`
`37`	`37`	`public void dummyCustomerApiTest() {`
`38`	`38`	`Tenant tenant = new Tenant("testTenant", 2);`
`39`		`- Throttler timer = new ThrottleTimerImpl(10);`
	`39`	`+ Throttler timer = new ThrottleTimerImpl(100);`
`40`	`40`	`B2BService service = new B2BService(timer);`
`41`		`-`
	`41`	`+`
`42`	`42`	`for (int i = 0; i < 5; i++) {`
`43`	`43`	`service.dummyCustomerApi(tenant);`
`44`	`44`	`}`
`45`		`-`
`46`		`- int counter = CallsCount.getCount(tenant.getName());`
	`45`	`+ long counter = CallsCount.getCount(tenant.getName());`
`47`	`46`	`Assert.assertTrue("Counter limit must be reached", counter == 2);`
`48`	`47`	`}`
`49`	`48`	`}`