Skip to content

Commit 9284a50

Browse files
tokokotokoko
authored
chore: Remove usage tracking (feast-dev#4214)
remove usage Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
1 parent bdae562 commit 9284a50

63 files changed

Lines changed: 116 additions & 1148 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Makefile‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,10 @@ lock-python-dependencies-all:
7171
pixi run --environment py311 --manifest-path infra/scripts/pixi/pixi.toml "uv pip compile --system --no-strip-extras setup.py --extra ci --output-file sdk/python/requirements/py3.11-ci-requirements.txt"
7272

7373
benchmark-python:
74-
FEAST_USAGE=False IS_TEST=True python -m pytest --integration --benchmark --benchmark-autosave --benchmark-save-data sdk/python/tests
74+
IS_TEST=True python -m pytest --integration --benchmark --benchmark-autosave --benchmark-save-data sdk/python/tests
7575

7676
benchmark-python-local:
77-
FEAST_USAGE=False IS_TEST=True FEAST_IS_LOCAL_TEST=True python -m pytest --integration --benchmark --benchmark-autosave --benchmark-save-data sdk/python/tests
77+
IS_TEST=True FEAST_IS_LOCAL_TEST=True python -m pytest --integration --benchmark --benchmark-autosave --benchmark-save-data sdk/python/tests
7878

7979
test-python-unit:
8080
python -m pytest -n 8 --color=yes sdk/python/tests
@@ -372,7 +372,7 @@ start-trino-locally:
372372
sleep 15
373373

374374
test-trino-plugin-locally:
375-
cd ${ROOT_DIR}/sdk/python; FULL_REPO_CONFIGS_MODULE=feast.infra.offline_stores.contrib.trino_offline_store.test_config.manual_tests FEAST_USAGE=False IS_TEST=True python -m pytest --integration tests/
375+
cd ${ROOT_DIR}/sdk/python; FULL_REPO_CONFIGS_MODULE=feast.infra.offline_stores.contrib.trino_offline_store.test_config.manual_tests IS_TEST=True python -m pytest --integration tests/
376376

377377
kill-trino-locally:
378378
cd ${ROOT_DIR}; docker stop trino

‎docs/how-to-guides/adding-or-reusing-tests.md‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ $ tree
2121
│ ├── test_go_feature_server.py
2222
│ ├── test_python_feature_server.py
2323
│ ├── test_universal_e2e.py
24-
│ ├── test_usage_e2e.py
2524
│ └── test_validation.py
2625
├── feature_repos
2726
│ ├── integration_test_repo_config.py
@@ -99,8 +98,6 @@ If a test can be run purely locally (where locally includes Docker resources), i
9998
* `test_go_feature_server.py`
10099
* python http server
101100
* `test_python_feature_server.py`
102-
* usage tracking
103-
* `test_usage_e2e.py`
104101
* data quality monitoring feature validation
105102
* `test_validation.py`
106103
2. Offline and Online Store Tests
@@ -149,7 +146,6 @@ If a test can be run purely locally (where locally includes Docker resources), i
149146
* Type mapping
150147
* Feast types
151148
* Serialization tests due to this [issue](https://github.com/feast-dev/feast/issues/2345)
152-
* Feast usage tracking unit tests
153149

154150
#### Docstring tests
155151

‎docs/how-to-guides/customizing-feast/adding-a-new-offline-store.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ test-python-universal-spark:
417417
PYTHONPATH='.' \
418418
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.offline_stores.contrib.spark_repo_configuration \
419419
PYTEST_PLUGINS=feast.infra.offline_stores.contrib.spark_offline_store.tests \
420-
FEAST_USAGE=False IS_TEST=True \
420+
IS_TEST=True \
421421
python -m pytest -n 8 --integration \
422422
-k "not test_historical_retrieval_fails_on_validation and \
423423
not test_historical_retrieval_with_validation and \

‎docs/how-to-guides/customizing-feast/adding-support-for-a-new-online-store.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,6 @@ test-python-universal-cassandra:
374374
PYTHONPATH='.' \
375375
FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.contrib.cassandra_repo_configuration \
376376
PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.cassandra \
377-
FEAST_USAGE=False \
378377
IS_TEST=True \
379378
python -m pytest -x --integration \
380379
sdk/python/tests

‎docs/reference/usage.md‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎infra/scripts/test-end-to-end.sh‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,5 @@ make build-java-no-tests REVISION=develop
1010
python -m pip install --upgrade pip setuptools wheel pip-tools
1111
make install-python
1212
python -m pip install -qr tests/requirements.txt
13-
export FEAST_USAGE="False"
1413

1514
su -p postgres -c "PATH=$PATH HOME=/tmp pytest -v tests/e2e/ --feast-version develop"

‎sdk/python/docs/source/feast.rst‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -321,14 +321,6 @@ feast.ui\_server module
321321
:undoc-members:
322322
:show-inheritance:
323323

324-
feast.usage module
325-
------------------
326-
327-
.. automodule:: feast.usage
328-
:members:
329-
:undoc-members:
330-
:show-inheritance:
331-
332324
feast.utils module
333325
------------------
334326

‎sdk/python/feast/batch_feature_view.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import warnings
22
from datetime import datetime, timedelta
3-
from typing import Dict, List, Optional, Tuple, Union
3+
from typing import Dict, List, Optional, Tuple
44

55
from feast import flags_helper
66
from feast.data_source import DataSource
@@ -60,7 +60,7 @@ def __init__(
6060
*,
6161
name: str,
6262
source: DataSource,
63-
entities: Optional[Union[List[Entity], List[str]]] = None,
63+
entities: Optional[List[Entity]] = None,
6464
ttl: Optional[timedelta] = None,
6565
tags: Optional[Dict[str, str]] = None,
6666
online: bool = True,

‎sdk/python/feast/cli.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def ui(
162162
host: str,
163163
port: int,
164164
registry_ttl_sec: int,
165-
root_path: Optional[str] = "",
165+
root_path: str = "",
166166
):
167167
"""
168168
Shows the Feast UI over the current directory
@@ -807,12 +807,12 @@ def validate(
807807
"""
808808
store = create_feature_store(ctx)
809809

810-
feature_service = store.get_feature_service(name=feature_service)
811-
reference = store.get_validation_reference(reference)
810+
_feature_service = store.get_feature_service(name=feature_service)
811+
_reference = store.get_validation_reference(reference)
812812

813813
result = store.validate_logged_features(
814-
source=feature_service,
815-
reference=reference,
814+
source=_feature_service,
815+
reference=_reference,
816816
start=maybe_local_tz(datetime.fromisoformat(start_ts)),
817817
end=maybe_local_tz(datetime.fromisoformat(end_ts)),
818818
throw_exception=False,

‎sdk/python/feast/constants.py‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@
2929
# Environment variable for registry
3030
REGISTRY_ENV_NAME: str = "REGISTRY_BASE64"
3131

32-
# Environment variable for toggling the Usage feature
33-
FEAST_USAGE = "FEAST_USAGE"
34-
35-
# Environment variable for FEAST_USAGE_ENDPOINT
36-
FEAST_USAGE_ENDPOINT = "FEAST_USAGE_ENDPOINT"
37-
3832
# Environment variable for the path for overwriting universal test configs
3933
FULL_REPO_CONFIGS_MODULE_ENV_NAME: str = "FULL_REPO_CONFIGS_MODULE"
4034

0 commit comments

Comments
 (0)