Upload benchmark information to S3 after integration test runs (feast-dev#1878)

achals · web-flow · commit 463b88fe7297 · 2021-09-17T12:59:11.000-07:00
* Upload benchmark information to S3 after integration test runs

Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;

* Fix action

Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;

* newline

Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/.github/workflows/integration_tests.yml b/.github/workflows/integration_tests.yml
@@ -63,9 +63,6 @@ jobs:
           fail_ci_if_error: true
           verbose: true
       - name: Benchmark python
-        run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-json=./benchmarks.json
-      - name: Upload Benchmark Artifact
-        uses: actions/upload-artifact@v2
-        with:
-          name: benchmarks.json
-          path: benchmarks.json
+        run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-autosave --benchmark-save-data
+      - name: Upload Benchmark Artifact to S3
+        run: aws s3 cp --recursive .benchmarks s3://feast-ci-pytest-benchmarks
diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml
@@ -74,9 +74,6 @@ jobs:
           fail_ci_if_error: true
           verbose: true
       - name: Benchmark python
-        run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-json=./benchmarks.json
-      - name: Upload Benchmark Artifact
-        uses: actions/upload-artifact@v2
-        with:
-          name: benchmarks.json
-          path: benchmarks.json
+        run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-autosave --benchmark-save-data
+      - name: Upload Benchmark Artifact to S3
+        run: aws s3 cp --recursive .benchmarks s3://feast-ci-pytest-benchmarks
diff --git a/.gitignore b/.gitignore
@@ -187,4 +187,7 @@ dmypy.json
 # Protos
 sdk/python/docs/html
 sdk/python/feast/protos/
-sdk/go/protos/
+sdk/go/protos/
+
+#benchmarks
+.benchmarks
diff --git a/Makefile b/Makefile
@@ -53,7 +53,7 @@ install-python:
 	python -m pip install -e sdk/python -U --use-deprecated=legacy-resolver
 
 benchmark-python:
-	FEAST_USAGE=False IS_TEST=True pytest --integration --benchmark sdk/python/tests
+	FEAST_USAGE=False IS_TEST=True pytest --integration --benchmark  --benchmark-autosave --benchmark-save-data sdk/python/tests
 
 test-python:
 	FEAST_USAGE=False IS_TEST=True pytest -n 8 sdk/python/tests
