Skip to content

Broken browser builds #1398

Closed
Closed

Description

@dcodeIO

As mentioned in #1238 (comment), there is a strange problem with path.relative as used in asc since merging asconfig.

In particular

path.relative(".", "module.ts");

returns odule.ts in browser builds, but for some reason the following

const path = require("path-browserify");
path.relative(".", "module.ts");

returns module.ts as expected. What's known so far:

  • webpack bundles path-browserify v0.0.1
  • newest version is v1.0.1
  • Problem seems to happen here:
    exports.relative = function(from, to) {
      from = exports.resolve(from).substr(1);
      to = exports.resolve(to).substr(1); // <---
  • ?!

In general there appears to be another aspect to this since it's not easily reproducible outside of bundles. If you have any clue, please enlighten me :)

Activity

  1. dcodeIO commented on Jul 19, 2020

    @dcodeIO
    MemberAuthor
  2. github-actions commented on Jul 23, 2020

    @github-actions

    🎉 This issue has been resolved in version 0.14.3 🎉

    The release is available on:

    Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions