Add a check so setting src on async image multiple times wont mismatch imageSource

PanayotCankov · PanayotCankov · commit f8ee9939344b · 2016-06-09T15:58:39.000+03:00
diff --git a/expect.exp b/expect.exp
@@ -16,5 +16,5 @@ set timeout 600
 #spawn (adb logcat | tee ./__TESTRESULT__.txt)
 log_file -noappend $outfile
 eval spawn $cmd
-expect "=== ALL TESTS COMPLETE ==="
+expect "Tests EOF!"
 send \003
diff --git a/tests/app/testRunner.ts b/tests/app/testRunner.ts
@@ -153,17 +153,20 @@ function printRunTestStats() {
 
     testFileContent = testFileContent.concat(testCases);
 
-// DO NOT CHANGE THE FIRST ROW! Used as an indicator for test run pass detection.
-    let finalMessage = `=== ALL TESTS COMPLETE ===\n` +
+    let finalMessage = `\n=== ALL TESTS COMPLETE ===\n` +
         `${(allTests.length - failedTestCount)} OK, ${failedTestCount} failed\n` + 
-        `DURATION: ${totalTime} ms`;
+        `DURATION: ${totalTime} ms\n`;
     TKUnit.write(finalMessage, messageType.info);
+
     for (j = 0; j < failedTestInfo.length; j++) {
         let failureMessage = failedTestInfo[j];
         TKUnit.write(failureMessage, messageType.error);
         finalMessage += "\n" + failureMessage;
     }
 
+    // DO NOT CHANGE THE FIRST ROW! Used as an indicator for test run pass detection.
+    TKUnit.write(`Tests EOF!`, messageType.info);
+
     testFileContent.push("</testsuite>");
     testFileContent.push("</testsuites>");
 
diff --git a/tests/app/ui/image/image-tests.ts b/tests/app/ui/image/image-tests.ts
@@ -2,6 +2,8 @@
 import {StackLayout} from "ui/layouts/stack-layout";
 import {GridLayout} from "ui/layouts/grid-layout";
 import {isIOS} from "platform";
+import {PropertyChangeData} from "data/observable";
+
 // import {target} from "../../TKUnit";
 
 import TKUnit = require("../../TKUnit");
@@ -133,6 +135,28 @@ export var test_SettingImageSrcToDataURIAsync = function (done) {
     runImageTest(done, image, image.src)
 }
 
+// NOTE: This tests that setting multiple times src will not show the imageSource of a previous src value.
+// It however will never be reliable as to properly detect failure we need to use somewhat large timeout
+// waiting for imageSource to be set to the wrong value.
+export var __test_SettingImageSrcTwiceMustNotMismatch = function(done) {
+    var image = new Image();
+    image.on("propertyChange", (args: PropertyChangeData) => {
+        if (args.propertyName === "isLoading" && args.value === false) {
+            setTimeout(() => {
+                if (image.imageSource) {
+                    done(new Error("Images source set from previous async src setting"));
+                } else {
+                    done();
+                }
+            }, 50); /* Slow! */
+        }
+    });
+    image.loadMode = "async";
+    image.src = "~/logo.png";
+    image.src = null;
+    // At somepoint image.imageSource was set to "~/logo.png";
+}
+
 export var test_SettingStretch_AspectFit = function () {
     // >> img-set-stretch
     var image = new ImageModule.Image();
diff --git a/tns-core-modules/ui/image/image-common.ts b/tns-core-modules/ui/image/image-common.ts
@@ -97,6 +97,9 @@ export class Image extends view.View implements definition.Image {
 
             var source = new imageSource.ImageSource();
             var imageLoaded = () => {
+                if (value !== this.src) {
+                    return;
+                }
                 this.imageSource = source;
                 this._setValue(Image.isLoadingProperty, false);
             }
@@ -143,9 +146,11 @@ export class Image extends view.View implements definition.Image {
         else if (value instanceof imageSource.ImageSource) {
             // Support binding the imageSource trough the src property
             this.imageSource = value;
+            this._setValue(Image.isLoadingProperty, false);
         }
         else {
             this.imageSource = imageSource.fromNativeSource(value);
+            this._setValue(Image.isLoadingProperty, false);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,9 @@ export class Image extends view.View implements definition.Image {`
`97`	`97`
`98`	`98`	`var source = new imageSource.ImageSource();`
`99`	`99`	`var imageLoaded = () => {`
	`100`	`+ if (value !== this.src) {`
	`101`	`+ return;`
	`102`	`+ }`
`100`	`103`	`this.imageSource = source;`
`101`	`104`	`this._setValue(Image.isLoadingProperty, false);`
`102`	`105`	`}`
`@@ -143,9 +146,11 @@ export class Image extends view.View implements definition.Image {`
`143`	`146`	`else if (value instanceof imageSource.ImageSource) {`
`144`	`147`	`// Support binding the imageSource trough the src property`
`145`	`148`	`this.imageSource = value;`
	`149`	`+ this._setValue(Image.isLoadingProperty, false);`
`146`	`150`	`}`
`147`	`151`	`else {`
`148`	`152`	`this.imageSource = imageSource.fromNativeSource(value);`
	`153`	`+ this._setValue(Image.isLoadingProperty, false);`
`149`	`154`	`}`
`150`	`155`	`}`
`151`	`156`	`}`