[fix] Update verve pattern. [hotfix] wrong auth check for otp

ibrahimlawal · ibrahimlawal · commit a872c07dcbfb · 2017-06-16T09:59:51.000+01:00
diff --git a/paystack/src/main/java/co/paystack/android/TransactionManager.java b/paystack/src/main/java/co/paystack/android/TransactionManager.java
@@ -195,7 +195,7 @@ public void onTick(long millisUntilFinished) {
                 new AuthAsyncTask().execute();
                 return;
             }
-            if (transactionApiResponse.hasValidAuth() && (transactionApiResponse.auth.equalsIgnoreCase("PIN") || transactionApiResponse.auth.equalsIgnoreCase("phone")) && transactionApiResponse.hasValidOtpMessage()) {
+            if (transactionApiResponse.hasValidAuth() && (transactionApiResponse.auth.equalsIgnoreCase("otp") || transactionApiResponse.auth.equalsIgnoreCase("phone")) && transactionApiResponse.hasValidOtpMessage()) {
                 transactionCallback.beforeValidate(transaction);
                 validateRequestBody.setTrans(transaction.getId());
                 osi.setOtpMessage(transactionApiResponse.otpmessage);
diff --git a/paystack/src/main/java/co/paystack/android/model/Card.java b/paystack/src/main/java/co/paystack/android/model/Card.java
@@ -530,7 +530,7 @@ public static abstract class CardType {
         static final String PATTERN_DINERS_CLUB = "^3(?:0[0-5]|[68][0-9])[0-9]{4,}$";
         static final String PATTERN_DISCOVER = "^6(?:011|5[0-9]{2})[0-9]{3,}$";
         static final String PATTERN_JCB = "^(?:2131|1800|35[0-9]{3})[0-9]{3,}$";
-        static final String PATTERN_VERVE = "^506[0-9]{6,}$";
+        static final String PATTERN_VERVE = "^((506(0|1))|(507(8|9))|(6500))[0-9]{12,}$";
 
         public abstract boolean matches(String card);
 

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ public void onTick(long millisUntilFinished) {`
`195`	`195`	`new AuthAsyncTask().execute();`
`196`	`196`	`return;`
`197`	`197`	`}`
`198`		`- if (transactionApiResponse.hasValidAuth() && (transactionApiResponse.auth.equalsIgnoreCase("PIN") \|\| transactionApiResponse.auth.equalsIgnoreCase("phone")) && transactionApiResponse.hasValidOtpMessage()) {`
	`198`	`+ if (transactionApiResponse.hasValidAuth() && (transactionApiResponse.auth.equalsIgnoreCase("otp") \|\| transactionApiResponse.auth.equalsIgnoreCase("phone")) && transactionApiResponse.hasValidOtpMessage()) {`
`199`	`199`	`transactionCallback.beforeValidate(transaction);`
`200`	`200`	`validateRequestBody.setTrans(transaction.getId());`
`201`	`201`	`osi.setOtpMessage(transactionApiResponse.otpmessage);`