Skip to content

Commit f792342

Browse files
committed
Ignore internal api in api comparison
1 parent b81c057 commit f792342

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ jobs:
3535
architecture: ${{ matrix.arch }}
3636

3737
- name: Build with Maven
38-
run: mvn test jacoco:report -B -"Dgpg.skip"
38+
run: mvn verify -B -"Dgpg.skip"

pom.xml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,21 +170,24 @@
170170
<plugin>
171171
<groupId>com.github.siom79.japicmp</groupId>
172172
<artifactId>japicmp-maven-plugin</artifactId>
173-
<version>0.14.0</version>
173+
<version>0.14.3</version>
174174
<configuration>
175175
<parameter>
176176
<onlyModified>true</onlyModified>
177+
<accessModifier>public</accessModifier>
177178
<breakBuildBasedOnSemanticVersioning>true</breakBuildBasedOnSemanticVersioning>
178179
<excludes>
179180
<!-- JDK9 removed the Nameservice SPI as per bug 8134577. -->
180181
<exclude>org.xbill.DNS.spi</exclude>
182+
<!-- internal API detected as public -->
183+
<exclude>org.xbill.DNS.config.IPHlpAPI</exclude>
181184
</excludes>
182185
</parameter>
183186
</configuration>
184187
<executions>
185188
<execution>
186189
<id>check-compatibility</id>
187-
<phase>package</phase>
190+
<phase>verify</phase>
188191
<goals>
189192
<goal>cmp</goal>
190193
</goals>

0 commit comments

Comments
 (0)