Minor RadarChart fix for unequal datasets in terms of entry count

PhilJay · PhilJay · commit ebbea0651ba4 · 2016-02-25T00:28:10.000+01:00
diff --git a/MPChartLib/src/com/github/mikephil/charting/data/ChartData.java b/MPChartLib/src/com/github/mikephil/charting/data/ChartData.java
@@ -186,8 +186,9 @@ private void checkLegal() {
     }
 
     /**
-     * Call this method to let the CartData know that the underlying data has
-     * changed.
+     * Call this method to let the ChartData know that the underlying data has
+     * changed. Calling this performs all necessary recalculations needed when
+     * the contained data has changed.
      */
     public void notifyDataChanged() {
         init();
diff --git a/MPChartLib/src/com/github/mikephil/charting/renderer/RadarChartRenderer.java b/MPChartLib/src/com/github/mikephil/charting/renderer/RadarChartRenderer.java
@@ -57,12 +57,29 @@ public void drawData(Canvas c) {
 
         for (IRadarDataSet set : radarData.getDataSets()) {
 
-            if (set.isVisible() && set.getEntryCount() > 0)
-                drawDataSet(c, set);
+            if (set.isVisible() && set.getEntryCount() > 0) {
+
+                int mostEntries = 0;
+
+                for (IRadarDataSet radarSet : radarData.getDataSets()) {
+                    if (set != radarSet && radarSet.getEntryCount() > mostEntries) {
+                        mostEntries = radarSet.getEntryCount();
+                    }
+                }
+
+                drawDataSet(c, set, mostEntries);
+            }
         }
     }
 
-    protected void drawDataSet(Canvas c, IRadarDataSet dataSet) {
+    /**
+     * Draws the RadarDataSet
+     *
+     * @param c
+     * @param dataSet
+     * @param mostEntries the entry count of the dataset with the most entries
+     */
+    protected void drawDataSet(Canvas c, IRadarDataSet dataSet, int mostEntries) {
 
         float phaseX = mAnimator.getPhaseX();
         float phaseY = mAnimator.getPhaseY();
@@ -100,7 +117,15 @@ protected void drawDataSet(Canvas c, IRadarDataSet dataSet) {
                 surface.lineTo(p.x, p.y);
         }
 
-        surface.close();
+        // if this is the largest set, close it
+        if (dataSet.getEntryCount() >= mostEntries) {
+            surface.close();
+        } else {
+
+            // if this is not the largest set, draw a line to the center and then close it
+            surface.lineTo(center.x, center.y);
+            surface.close();
+        }
 
         final Drawable drawable = dataSet.getFillDrawable();
         if (drawable != null) {
