Revert "Never load a module targeting the PSReadLine module's SessionState" (PowerShell#25792)

daxian-dbw · Amro Khalil · commit 1df5286191c5 · 2025-08-13T00:51:44.000+04:00
The change causes nested modules of PSReadLine to be loaded to global session state as well.

It's possible to check if we are currently importing the PSReadLine module but the check would depend on the current design of the PSReadLine module, such as how many nested modules it has, its module type, and etc., which is fragile. It's safer to just revert the change.
diff --git a/src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs b/src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
@@ -136,12 +136,17 @@ protected internal struct ImportModuleOptions
 
         internal SessionState TargetSessionState
         {
-            // Module loading could happen during tab completion triggered by PSReadLine,
-            // but that doesn't mean the module should be loaded targeting the PSReadLine
-            // module's session state. In that case, use Global session state instead.
-            get => BaseGlobal || Context.EngineSessionState.Module?.Name is "PSReadLine"
-                ? Context.TopLevelSessionState.PublicSessionState
-                : Context.SessionState;
+            get
+            {
+                if (BaseGlobal)
+                {
+                    return this.Context.TopLevelSessionState.PublicSessionState;
+                }
+                else
+                {
+                    return this.Context.SessionState;
+                }
+            }
         }
 
         /// <summary>
