Refactor bubble_sort

Cigan Oliviu David · abranhe · commit e53da6986845 · 2021-07-15T09:55:21.000-04:00
diff --git a/algorithms/sorting/bubble_sort.cpp b/algorithms/sorting/bubble_sort.cpp
@@ -8,47 +8,80 @@
 // Contributed by: Abhishek Jaiswal
 // Github: @Abhishek-iiit
 //
-#include<stdio.h>
-#include<iostream>
-
-using namespace std;
-
-void bubbleSort(int arr[], int n) 
-{ 
-   int i, j; 
-   bool changed; 
-   for (i = 0; i < n-1; i++) 
-   { 
-     changed = false; 
-     for (j = 0; j < n-i-1; j++) 
-     { 
-        if (arr[j] > arr[j+1]) 
-        { 
-           swap(arr[j],arr[j+1]); 
-            changed = true; 
+// Refactoring by: Cigan Oliviu David
+// Github: @CiganOliviu
+//
+
+#include <iostream>
+
+
+unsigned int readLength() {
+
+    unsigned int length;
+
+    std::cin >> length;
+
+    return length;
+}
+
+void readArray(int array[], unsigned int length) {
+
+    for (int i = 0; i < length; i++)
+        std::cin >> array[i];
+}
+
+
+void bubbleSortArray(int array[], unsigned int length)  {
+
+    bool changed;
+
+    length -= 1;
+
+    for (int i = 0; i < length; i++) { 
+
+        changed = false; 
+
+        for (int j = 0; j < length - i; j++) { 
+
+            if (array[j] > array[j + 1]) {
+ 
+                std::swap(array[j], array[j+1]);            
+                changed = true; 
+            } 
         } 
-     } 
-     if (changed == false)
-        break; 
-   } 
-} 
-
-int main()
-{
-    int n;
-    cout<<"Input the total size :"<<endl;
-    cin>>n;
-    int arr[n];
-    cout<<"Input the number one-by-one :"<<endl;
-    for(int i=0;i<n;i++)
-    {
-        cin>>arr[i];
-    }
-    bubbleSort(arr,n);
-    cout<<"Sorted array:"<<endl;
-    for(int i=0;i<n;i++)
-    {
-        cout<<arr[i]<<" ";
-    }
+
+        if (changed == false)
+            return;
+    } 
+}
+
+void outputArray(int array[], unsigned int length) {
+
+    for (int i = 0; i < length; i++)
+        std::cout << array[i] << " ";
+
+    std::cout << '\n';
+}
+
+int main() {  
+    
+    std::cout << "Input the total size : ";
+    
+    unsigned int length;
+    
+    length = readLength();
+
+    int array[length];
+    
+    std::cout << "Input the number one-by-one : ";
+
+    readArray(array, length);
+
+    bubbleSortArray(array, length);
+    
+    std::cout << "Sorted array:" << std::endl;
+    
+    outputArray(array, length);
+
     return 0;
 }
