Skip to content

Commit 505e82e

Browse files
knopers8Barthelemy
andauthored
[QC-585] Pass Monitoring URL to Mergers (#708)
* [QC-585] Pass Monitoring URL to Mergers * delete empty line * trigger new build * fix test Co-authored-by: Barthélémy von Haller <barthelemy.von.haller@gmail.com>
1 parent d7d245c commit 505e82e

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

Framework/include/QualityControl/InfrastructureGenerator.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,8 @@ class InfrastructureGenerator
149149
std::string taskName,
150150
size_t numberOfLocalMachines,
151151
double cycleDurationSeconds,
152-
std::string mergingMode);
152+
std::string mergingMode,
153+
std::string monitoringUrl);
153154
static vector<framework::OutputSpec> generateCheckRunners(framework::WorkflowSpec& workflow, std::string configurationSource);
154155
static void generateAggregator(framework::WorkflowSpec& workflow, std::string configurationSource, vector<framework::OutputSpec>& checkRunnerOutputs);
155156
static void generatePostProcessing(framework::WorkflowSpec& workflow, std::string configurationSource);

Framework/src/InfrastructureGenerator.cxx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,8 @@ o2::framework::WorkflowSpec InfrastructureGenerator::generateRemoteInfrastructur
213213

214214
generateMergers(workflow, taskName, numberOfLocalMachines,
215215
taskConfig.get<double>("cycleDurationSeconds"),
216-
taskConfig.get<std::string>("mergingMode", "delta"));
216+
taskConfig.get<std::string>("mergingMode", "delta"),
217+
config->get<std::string>("qc.config.monitoring.url"));
217218

218219
} else if (taskConfig.get<std::string>("location") == "remote") {
219220

@@ -369,7 +370,7 @@ void InfrastructureGenerator::generateLocalTaskRemoteProxy(framework::WorkflowSp
369370

370371
void InfrastructureGenerator::generateMergers(framework::WorkflowSpec& workflow, std::string taskName,
371372
size_t numberOfLocalMachines, double cycleDurationSeconds,
372-
std::string mergingMode)
373+
std::string mergingMode, std::string monitoringUrl)
373374
{
374375
Inputs mergerInputs;
375376
for (size_t id = 1; id <= numberOfLocalMachines; id++) {
@@ -390,8 +391,9 @@ void InfrastructureGenerator::generateMergers(framework::WorkflowSpec& workflow,
390391
mergerConfig.inputObjectTimespan = { (mergingMode.empty() || mergingMode == "delta") ? InputObjectsTimespan::LastDifference : InputObjectsTimespan::FullHistory };
391392
mergerConfig.publicationDecision = { PublicationDecision::EachNSeconds, cycleDurationSeconds };
392393
mergerConfig.mergedObjectTimespan = { MergedObjectTimespan::FullHistory, 0 };
393-
// for now one merger should be enough, multiple layers to be supported later
394+
// for now one merger should be enough, multiple layers will be supported later
394395
mergerConfig.topologySize = { TopologySize::NumberOfLayers, 1 };
396+
mergerConfig.monitoringUrl = monitoringUrl;
395397
mergersBuilder.setConfig(mergerConfig);
396398

397399
mergersBuilder.generateInfrastructure(workflow);

Framework/test/testSharedConfig.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
"Activity": {
1212
"number": "42",
1313
"type": "2"
14+
},
15+
"monitoring": {
16+
"url": "infologger:///debug?qc"
1417
}
1518
},
1619
"tasks": {

0 commit comments

Comments
 (0)