Skip to content

Commit 4e4aa87

Browse files
knopers8teo
authored andcommitted
[core] 'task inactive exception' should be an error log
Sometimes this is the only message from aliecs to know which task failed. It is easy to miss when it is Info. It would be even better if it had partition id included, but did not find a way to retrieve it, it is not there even in Labels.
1 parent 729715b commit 4e4aa87

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

core/task/manager.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,8 +1120,8 @@ func (m *Manager) handleMessage(tm *TaskmanMessage) error {
11201120
"message": mesosStatus.GetMessage(),
11211121
"level": infologger.IL_Devel,
11221122
}).
1123-
WithField("partition", tm.GetEnvironmentId().String()).
1124-
Info("task inactive exception")
1123+
WithField("partition", tm.GetEnvironmentId().String()). // fixme: this is empty!
1124+
Error("task inactive exception")
11251125
taskIDValue := mesosStatus.GetTaskID().Value
11261126
t := m.GetTask(taskIDValue)
11271127
if t != nil && t.IsLocked() {

0 commit comments

Comments
 (0)