DPL: Improve debugging of bad topologies. (#12315)

ktf · web-flow · commit fe2cb99e42a2 · 2023-11-24T13:19:19.000+01:00
Print dependency as graphviz digraph when topological sort fails.
diff --git a/Framework/Core/src/runDataProcessing.cxx b/Framework/Core/src/runDataProcessing.cxx
@@ -2590,6 +2590,11 @@ std::string debugTopoInfo(std::vector<DataProcessorSpec> const& specs,
   for (auto& d : specs) {
     out << "- " << d.name << std::endl;
   }
+  out << "digraph G {\n";
+  for (auto& e : edges) {
+    out << fmt::format("  \"{}\" -> \"{}\"\n", specs[e.first].name, specs[e.second].name);
+  }
+  out << "}\n";
   return out.str();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2590,6 +2590,11 @@ std::string debugTopoInfo(std::vector<DataProcessorSpec> const& specs,`
`2590`	`2590`	`for (auto& d : specs) {`
`2591`	`2591`	`out << "- " << d.name << std::endl;`
`2592`	`2592`	`}`
	`2593`	`+ out << "digraph G {\n";`
	`2594`	`+ for (auto& e : edges) {`
	`2595`	`+ out << fmt::format(" \"{}\" -> \"{}\"\n", specs[e.first].name, specs[e.second].name);`
	`2596`	`+ }`
	`2597`	`+ out << "}\n";`
`2593`	`2598`	`return out.str();`
`2594`	`2599`	`}`
`2595`	`2600`