Hmpid fix decoder bug (#12391)

fapfap69 · Antonio Franco · web-flow · commit f1537df7e2fe · 2023-12-07T13:30:12.000+01:00
* Fix the bug jira ticket O2-4243

* Fix CLang error

---------

Co-authored-by: Antonio Franco &lt;antonio.franco@cern.ch&gt;
diff --git a/Detectors/HMPID/reconstruction/src/HmpidDecoder2.cxx b/Detectors/HMPID/reconstruction/src/HmpidDecoder2.cxx
@@ -133,6 +133,7 @@ void HmpidDecoder2::init()
   for (int i = 0; i < mNumberOfEquipments; i++) {
     mTheEquipments[i]->init();
     mTheEquipments[i]->resetPadMap();
+    mTheEquipments[i]->resetErrors();
   }
 
   mDigits.clear();
@@ -1276,7 +1277,7 @@ bool HmpidDecoder2::setUpStream(void* Buffer, long BufferLen)
   }
 
   mActualStreamPtr = (uint32_t*)Buffer;                 // sets the pointer to the Buffer
-  mEndStreamPtr = ((uint32_t*)Buffer) + wordsBufferLen; // sets the End of buffer
+  mEndStreamPtr = ((uint32_t*)Buffer) + wordsBufferLen - 1; // sets the End of buffer
   mStartStreamPtr = ((uint32_t*)Buffer);
   return (true);
 }
diff --git a/Detectors/HMPID/workflow/src/DataDecoderSpec2.cxx b/Detectors/HMPID/workflow/src/DataDecoderSpec2.cxx
@@ -213,7 +213,7 @@ void DataDecoderTask2::decodeTF(framework::ProcessingContext& pc)
       // The stream end !
       LOG(debug) << "End Page decoding !";
     }
-    //   std::cout << ">>>>" << pointerToTheFirst << "," << mDeco->mDigits.size() << std::endl;
+    // std::cout << "  fDigit=" << pointerToTheFirst << " lDigit=," << mDeco->mDigits.size() << " nDigit=" << mDeco->mDigits.size()-pointerToTheFirst << std::endl;
     mTriggers.push_back(o2::hmpid::Trigger(mDeco->mIntReco, pointerToTheFirst, mDeco->mDigits.size() - pointerToTheFirst));
     mTotalFrames++;
   }

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ void HmpidDecoder2::init()`
`133`	`133`	`for (int i = 0; i < mNumberOfEquipments; i++) {`
`134`	`134`	`mTheEquipments[i]->init();`
`135`	`135`	`mTheEquipments[i]->resetPadMap();`
	`136`	`+ mTheEquipments[i]->resetErrors();`
`136`	`137`	`}`
`137`	`138`
`138`	`139`	`mDigits.clear();`
`@@ -1276,7 +1277,7 @@ bool HmpidDecoder2::setUpStream(void* Buffer, long BufferLen)`
`1276`	`1277`	`}`
`1277`	`1278`
`1278`	`1279`	`mActualStreamPtr = (uint32_t*)Buffer; // sets the pointer to the Buffer`
`1279`		`- mEndStreamPtr = ((uint32_t*)Buffer) + wordsBufferLen; // sets the End of buffer`
	`1280`	`+ mEndStreamPtr = ((uint32_t*)Buffer) + wordsBufferLen - 1; // sets the End of buffer`
`1280`	`1281`	`mStartStreamPtr = ((uint32_t*)Buffer);`
`1281`	`1282`	`return (true);`
`1282`	`1283`	`}`
Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ void DataDecoderTask2::decodeTF(framework::ProcessingContext& pc)`
`213`	`213`	`// The stream end !`
`214`	`214`	`LOG(debug) << "End Page decoding !";`
`215`	`215`	`}`
`216`		`- // std::cout << ">>>>" << pointerToTheFirst << "," << mDeco->mDigits.size() << std::endl;`
	`216`	`+ // std::cout << " fDigit=" << pointerToTheFirst << " lDigit=," << mDeco->mDigits.size() << " nDigit=" << mDeco->mDigits.size()-pointerToTheFirst << std::endl;`
`217`	`217`	`mTriggers.push_back(o2::hmpid::Trigger(mDeco->mIntReco, pointerToTheFirst, mDeco->mDigits.size() - pointerToTheFirst));`
`218`	`218`	`mTotalFrames++;`
`219`	`219`	`}`