Skip to content

Commit dca8bb5

Browse files
Introducing common_boost_bucket avoiding warnings in boost headers
Bucket declares ${Boost_INCLUDE_DIR} as SYSTEM include, other common dependencies can be moved later.
1 parent 07d2d69 commit dca8bb5

1 file changed

Lines changed: 21 additions & 11 deletions

File tree

cmake/O2Dependencies.cmake

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,23 @@ endif()
5656

5757
########## Bucket definitions ############
5858

59+
o2_define_bucket(
60+
NAME
61+
common_boost_bucket
62+
63+
SYSTEMINCLUDE_DIRECTORIES
64+
${Boost_INCLUDE_DIR}
65+
)
66+
5967
o2_define_bucket(
6068
NAME
6169
ExampleModule1_bucket
6270

6371
DEPENDENCIES # library names
72+
common_boost_bucket
6473
${Boost_PROGRAM_OPTIONS_LIBRARY}
6574

6675
INCLUDE_DIRECTORIES
67-
${Boost_INCLUDE_DIR}
6876
)
6977

7078
o2_define_bucket(
@@ -86,6 +94,7 @@ o2_define_bucket(
8694
flp2epn_bucket
8795

8896
DEPENDENCIES
97+
common_boost_bucket
8998
${Boost_CHRONO_LIBRARY}
9099
${Boost_DATE_TIME_LIBRARY}
91100
${Boost_LOG_LIBRARY}
@@ -100,7 +109,6 @@ o2_define_bucket(
100109

101110
INCLUDE_DIRECTORIES
102111
${FAIRROOT_INCLUDE_DIR}
103-
${Boost_INCLUDE_DIR}
104112
)
105113

106114
o2_define_bucket(
@@ -120,11 +128,11 @@ o2_define_bucket(
120128
common_math_bucket
121129

122130
DEPENDENCIES
131+
common_boost_bucket
123132
FairMQ ${Boost_LOG_LIBRARY} ${Boost_THREAD_LIBRARY} fairmq_logger Base FairTools Core MathCore Hist
124133

125134
INCLUDE_DIRECTORIES
126135
${FAIRROOT_INCLUDE_DIR}
127-
${Boost_INCLUDE_DIR}
128136
${ROOT_INCLUDE_DIR}
129137
)
130138

@@ -145,6 +153,7 @@ o2_define_bucket(
145153
CCDB_bucket
146154

147155
DEPENDENCIES
156+
common_boost_bucket
148157
${Boost_PROGRAM_OPTIONS_LIBRARY}
149158
${Boost_SYSTEM_LIBRARY}
150159
${Boost_THREAD_LIBRARY}
@@ -159,7 +168,6 @@ o2_define_bucket(
159168
INCLUDE_DIRECTORIES
160169
${ROOT_INCLUDE_DIR}
161170
${FAIRROOT_INCLUDE_DIR}
162-
${Boost_INCLUDE_DIR}
163171
)
164172

165173
o2_define_bucket(
@@ -179,11 +187,11 @@ o2_define_bucket(
179187

180188
DEPENDENCIES
181189
Base GeoBase ParBase Geom Core
190+
common_boost_bucket
182191

183192
INCLUDE_DIRECTORIES
184193
${ROOT_INCLUDE_DIR}
185194
${FAIRROOT_INCLUDE_DIR}
186-
${Boost_INCLUDE_DIR}
187195
)
188196

189197
o2_define_bucket(
@@ -193,11 +201,11 @@ o2_define_bucket(
193201
DEPENDENCIES
194202
root_base_bucket
195203
Base FairMQ FairTools ${Boost_LOG_LIBRARY} fairmq_logger Base
204+
common_boost_bucket
196205
${Boost_THREAD_LIBRARY} pthread
197206

198207
INCLUDE_DIRECTORIES
199208
${FAIRROOT_INCLUDE_DIR}
200-
${Boost_INCLUDE_DIR}
201209
)
202210

203211
o2_define_bucket(
@@ -295,13 +303,13 @@ o2_define_bucket(
295303
MathCore
296304
${Boost_LOG_LIBRARY}
297305
${Boost_SYSTEM_LIBRARY}
306+
common_boost_bucket
298307
FairMQ ${Boost_THREAD_LIBRARY} ${Boost_LOG_LIBRARY} fairmq_logger
299308
pthread
300309

301310
INCLUDE_DIRECTORIES
302311
${ROOT_INCLUDE_DIR}
303312
${FAIRROOT_INCLUDE_DIR}
304-
${Boost_INCLUDE_DIR}
305313
${ZMQ_INCLUDE_DIR}
306314
)
307315

@@ -317,14 +325,14 @@ o2_define_bucket(
317325
FairMQ
318326
pthread
319327
fairmq_logger
328+
common_boost_bucket
320329
${Boost_SYSTEM_LIBRARY}
321330
${Boost_LOG_LIBRARY}
322331
${Boost_LOG_SETUP_LIBRARY}
323332

324333
INCLUDE_DIRECTORIES
325334
${ROOT_INCLUDE_DIR}
326335
${FAIRROOT_INCLUDE_DIR}
327-
${Boost_INCLUDE_DIR}
328336
${ZMQ_INCLUDE_DIR}
329337
)
330338

@@ -418,6 +426,7 @@ o2_define_bucket(
418426
dl
419427
${CMAKE_THREAD_LIBS_INIT}
420428
${FAIRMQ_DEPENDENCIES}
429+
common_boost_bucket
421430
${Boost_CHRONO_LIBRARY}
422431
${Boost_DATE_TIME_LIBRARY}
423432
${Boost_PROGRAM_OPTIONS_LIBRARY}
@@ -432,9 +441,10 @@ o2_define_bucket(
432441

433442
INCLUDE_DIRECTORIES
434443
${FAIRROOT_INCLUDE_DIR}
435-
${Boost_INCLUDE_DIR}
436-
${ZMQ_INCLUDE_DIR}
437444
${OPTIONAL_DDS_INCLUDE_DIR}
445+
446+
SYSTEMINCLUDE_DIRECTORIES
447+
${ZMQ_INCLUDE_DIR}
438448
)
439449

440450
o2_define_bucket(
@@ -443,10 +453,10 @@ o2_define_bucket(
443453

444454
DEPENDENCIES
445455
Core RIO Gpad Hist HLTbase AliHLTUtil AliHLTTPC AliHLTUtil
456+
common_boost_bucket
446457
${Boost_SYSTEM_LIBRARY} ${Boost_FILESYSTEM_LIBRARY}
447458
dl
448459

449460
INCLUDE_DIRECTORIES
450461
${ROOT_INCLUDE_DIR}
451-
${Boost_INCLUDE_DIR}
452462
)

0 commit comments

Comments
 (0)