STFDecoder fetches ITS/MFT Alpide params from CCDB

shahor02 · shahor02 · commit cc39dd73dcb0 · 2022-06-15T22:24:49.000+02:00
diff --git a/Detectors/ITSMFT/common/workflow/src/STFDecoderSpec.cxx b/Detectors/ITSMFT/common/workflow/src/STFDecoderSpec.cxx
@@ -244,9 +244,14 @@ template <class Mapping>
 void STFDecoder<Mapping>::updateTimeDependentParams(ProcessingContext& pc)
 {
   // we call these methods just to trigger finaliseCCDB callback
-  pc.inputs().get<o2::itsmft::NoiseMap*>("noise");
-  if (mDoClusters) {
-    pc.inputs().get<o2::itsmft::TopologyDictionary*>("cldict");
+  static bool initOnceDone = false;
+  if (!initOnceDone) { // this params need to be queried only once
+    initOnceDone = true;
+    pc.inputs().get<o2::itsmft::NoiseMap*>("noise");
+    if (mDoClusters) {
+      pc.inputs().get<o2::itsmft::TopologyDictionary*>("cldict");
+      pc.inputs().get<o2::itsmft::DPLAlpideParam<Mapping::getDetID()>*>("alppar");
+    }
   }
 }
 
@@ -259,12 +264,19 @@ void STFDecoder<Mapping>::finaliseCCDB(o2::framework::ConcreteDataMatcher& match
     if (mApplyNoiseMap) {
       AlpideCoder::setNoisyPixels((const NoiseMap*)obj);
     }
+    return;
   }
   if (matcher == ConcreteDataMatcher(Mapping::getOrigin(), "CLUSDICT", 0)) {
     LOG(info) << Mapping::getName() << " cluster dictionary updated" << (!mUseClusterDictionary ? " but its using is disabled" : "");
     if (mUseClusterDictionary) {
       mClusterer->setDictionary((const TopologyDictionary*)obj);
     }
+    return;
+  }
+  // Note: strictly speaking, for Configurable params we don't need finaliseCCDB check, the singletons are updated at the CCDB fetcher level
+  if (matcher == ConcreteDataMatcher(Mapping::getOrigin(), "ALPIDEPARAM", 0)) {
+    LOG(info) << "Alpide param updated";
+    return;
   }
 }
 
@@ -302,6 +314,7 @@ DataProcessorSpec getSTFDecoderSpec(const STFDecoderInp& inp)
   if (inp.doClusters) {
     inputs.emplace_back("cldict", inp.origin, "CLUSDICT", 0, Lifetime::Condition,
                         o2::framework::ccdbParamSpec(fmt::format("{}/Calib/ClusterDictionary", inp.origin.as<std::string>())));
+    inputs.emplace_back("alppar", inp.origin, "ALPIDEPARAM", 0, Lifetime::Condition, ccdbParamSpec(fmt::format("{}/Config/AlpideParam", inp.origin.as<std::string>())));
   }
 
   return DataProcessorSpec{

Original file line number	Diff line number	Diff line change
`@@ -244,9 +244,14 @@ template <class Mapping>`
`244`	`244`	`void STFDecoder<Mapping>::updateTimeDependentParams(ProcessingContext& pc)`
`245`	`245`	`{`
`246`	`246`	`// we call these methods just to trigger finaliseCCDB callback`
`247`		`- pc.inputs().get<o2::itsmft::NoiseMap*>("noise");`
`248`		`- if (mDoClusters) {`
`249`		`- pc.inputs().get<o2::itsmft::TopologyDictionary*>("cldict");`
	`247`	`+ static bool initOnceDone = false;`
	`248`	`+ if (!initOnceDone) { // this params need to be queried only once`
	`249`	`+ initOnceDone = true;`
	`250`	`+ pc.inputs().get<o2::itsmft::NoiseMap*>("noise");`
	`251`	`+ if (mDoClusters) {`
	`252`	`+ pc.inputs().get<o2::itsmft::TopologyDictionary*>("cldict");`
	`253`	`+ pc.inputs().get<o2::itsmft::DPLAlpideParam<Mapping::getDetID()>*>("alppar");`
	`254`	`+ }`
`250`	`255`	`}`
`251`	`256`	`}`
`252`	`257`
`@@ -259,12 +264,19 @@ void STFDecoder<Mapping>::finaliseCCDB(o2::framework::ConcreteDataMatcher& match`
`259`	`264`	`if (mApplyNoiseMap) {`
`260`	`265`	`AlpideCoder::setNoisyPixels((const NoiseMap*)obj);`
`261`	`266`	`}`
	`267`	`+ return;`
`262`	`268`	`}`
`263`	`269`	`if (matcher == ConcreteDataMatcher(Mapping::getOrigin(), "CLUSDICT", 0)) {`
`264`	`270`	`LOG(info) << Mapping::getName() << " cluster dictionary updated" << (!mUseClusterDictionary ? " but its using is disabled" : "");`
`265`	`271`	`if (mUseClusterDictionary) {`
`266`	`272`	`mClusterer->setDictionary((const TopologyDictionary*)obj);`
`267`	`273`	`}`
	`274`	`+ return;`
	`275`	`+ }`
	`276`	`+ // Note: strictly speaking, for Configurable params we don't need finaliseCCDB check, the singletons are updated at the CCDB fetcher level`
	`277`	`+ if (matcher == ConcreteDataMatcher(Mapping::getOrigin(), "ALPIDEPARAM", 0)) {`
	`278`	`+ LOG(info) << "Alpide param updated";`
	`279`	`+ return;`
`268`	`280`	`}`
`269`	`281`	`}`
`270`	`282`
`@@ -302,6 +314,7 @@ DataProcessorSpec getSTFDecoderSpec(const STFDecoderInp& inp)`
`302`	`314`	`if (inp.doClusters) {`
`303`	`315`	`inputs.emplace_back("cldict", inp.origin, "CLUSDICT", 0, Lifetime::Condition,`
`304`	`316`	`o2::framework::ccdbParamSpec(fmt::format("{}/Calib/ClusterDictionary", inp.origin.as<std::string>())));`
	`317`	`+ inputs.emplace_back("alppar", inp.origin, "ALPIDEPARAM", 0, Lifetime::Condition, ccdbParamSpec(fmt::format("{}/Config/AlpideParam", inp.origin.as<std::string>())));`
`305`	`318`	`}`
`306`	`319`
`307`	`320`	`return DataProcessorSpec{`