Declaring as inline header defined function

victor-gonzalez · sawenzel · commit bfcc7c83443a · 2022-09-17T10:01:37.000+02:00
If the header file is include by several compiled unit which
happen to go to the same the linker complains about multiple
defined functions.
diff --git a/Framework/Core/include/Framework/BinningPolicy.h b/Framework/Core/include/Framework/BinningPolicy.h
@@ -22,7 +22,7 @@ namespace o2::framework
 
 namespace binning_helpers
 {
-void expandConstantBinning(std::vector<double> const& bins, std::vector<double>& expanded)
+inline void expandConstantBinning(std::vector<double> const& bins, std::vector<double>& expanded)
 {
   if (bins[0] != VARIABLE_WIDTH) {
     int nBins = static_cast<int>(bins[0]);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ namespace o2::framework`
`22`	`22`
`23`	`23`	`namespace binning_helpers`
`24`	`24`	`{`
`25`		`-void expandConstantBinning(std::vector<double> const& bins, std::vector<double>& expanded)`
	`25`	`+inline void expandConstantBinning(std::vector<double> const& bins, std::vector<double>& expanded)`
`26`	`26`	`{`
`27`	`27`	`if (bins[0] != VARIABLE_WIDTH) {`
`28`	`28`	`int nBins = static_cast<int>(bins[0]);`