CCDB: Add alien token check as proposed by Sandro

davidrohr · davidrohr · commit bf562dcf9685 · 2022-12-15T20:00:14.000+01:00
diff --git a/CCDB/include/CCDB/CcdbApi.h b/CCDB/include/CCDB/CcdbApi.h
@@ -63,6 +63,8 @@ class CcdbApi //: public DatabaseInterface
 
   const std::string getUniqueAgentID() const { return mUniqueAgentID; }
 
+  static bool checkAlienToken();
+
   /**
    * Initialize connection to CCDB
    *
diff --git a/CCDB/src/CcdbApi.cxx b/CCDB/src/CcdbApi.cxx
@@ -63,6 +63,25 @@ CcdbApi::~CcdbApi()
   curl_global_cleanup();
 }
 
+bool CcdbApi::checkAlienToken()
+{
+#ifdef __APPLE__
+  LOG(debug) << "On macOS we simply rely on TGrid::Connect(\"alien\").";
+  return true;
+#endif
+  if (getenv("ALICEO2_CCDB_NOTOKENCHECK") && atoi(getenv("ALICEO2_CCDB_NOTOKENCHECK"))) {
+    return true;
+  }
+  if (getenv("JALIEN_TOKEN_CERT")) {
+    return true;
+  }
+  auto returncode = system("alien-token-info &> /dev/nulll");
+  if (returncode == -1) {
+    LOG(error) << "...";
+  }
+  return returncode == 0;
+}
+
 void CcdbApi::curlInit()
 {
   // todo : are there other things to initialize globally for curl ?
@@ -120,7 +139,7 @@ void CcdbApi::init(std::string const& host)
   }
 
   const std::string httpsprefix = "https://";
-  mNeedAlienToken = host.substr(0, httpsprefix.size()) == httpsprefix) || host == "http://alice-ccdb.cern.ch";
+  mNeedAlienToken = host.substr(0, httpsprefix.size()) == httpsprefix || host == "http://alice-ccdb.cern.ch";
 
   LOGP(info, "Init CcdApi with UserAgentID: {}, Host: {}{}", mUniqueAgentID, host,
        mInSnapshotMode ? "(snapshot readonly mode)" : snapshotReport.c_str());
@@ -754,10 +773,13 @@ void* CcdbApi::extractFromLocalFile(std::string const& filename, std::type_info
 bool CcdbApi::initTGrid() const
 {
   if (mNeedAlienToken && !mAlienInstance) {
+    static bool allowNoToken = getenv("ALICEO2_CCDB_NOTOKENCHECK") && atoi(getenv("ALICEO2_CCDB_NOTOKENCHECK"));
+    if (!allowNoToken && !checkAlienToken()) {
+      LOG(fatal) << "Alien Token Check failed - Please get an alien token before running with https CCDB endpoint, or alice-ccdb.cern.ch!";
+    }
     mAlienInstance = TGrid::Connect("alien");
     static bool errorShown = false;
     if (!mAlienInstance && errorShown == false) {
-      bool allowNoToken = getenv("O2_CCDB_ALLOW_NO_TOKEN") && atoi(getenv("O2_CCDB_ALLOW_NO_TOKEN"));
       if (allowNoToken) {
         LOG(error) << "TGrid::Connect returned nullptr. May be due to missing alien token";
       } else {

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,8 @@ class CcdbApi //: public DatabaseInterface`
`63`	`63`
`64`	`64`	`const std::string getUniqueAgentID() const { return mUniqueAgentID; }`
`65`	`65`
	`66`	`+ static bool checkAlienToken();`
	`67`	`+`
`66`	`68`	`/**`
`67`	`69`	`* Initialize connection to CCDB`
`68`	`70`	`*`