Skip to content

Commit 8c69ec8

Browse files
davidrohrsawenzel
authored andcommitted
Add JOBUTILS_JOB_SKIPCREATEDONE option, and do not wipe ctf_dictionary in full system test if recreation task is not running
1 parent ec37ae1 commit 8c69ec8

2 files changed

Lines changed: 10 additions & 7 deletions

File tree

Utilities/Tools/jobutils.sh

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -348,10 +348,12 @@ taskwrapper() {
348348
RC=$?
349349
RC_ACUM=$((RC_ACUM+RC))
350350
if [ "${RC}" -eq "0" ]; then
351-
# if return code 0 we mark this task as done
352-
echo "Command \"${command}\" successfully finished." > "${logfile}"_done
353-
echo "The presence of this file can be used to skip this command in future runs" >> "${logfile}"_done
354-
echo "of the pipeline by setting the JOBUTILS_SKIPDONE environment variable." >> "${logfile}"_done
351+
if [ ! "${JOBUTILS_JOB_SKIPCREATEDONE}" ]; then
352+
# if return code 0 we mark this task as done
353+
echo "Command \"${command}\" successfully finished." > "${logfile}"_done
354+
echo "The presence of this file can be used to skip this command in future runs" >> "${logfile}"_done
355+
echo "of the pipeline by setting the JOBUTILS_SKIPDONE environment variable." >> "${logfile}"_done
356+
fi
355357
else
356358
echo "command ${command} had nonzero exit code ${RC}"
357359
fi

prodtests/full_system_test.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ if [ $ENABLE_GPU_TEST != "0" ]; then
7878
fi
7979
STAGES+=" ASYNC"
8080
for STAGE in $STAGES; do
81+
logfile=reco_${STAGE}.log
8182

8283
ARGS_ALL="--session default"
8384
DICTCREATION=""
@@ -90,7 +91,7 @@ for STAGE in $STAGES; do
9091
export CTFINPUT=0
9192
export SAVECTF=0
9293
elif [[ "$STAGE" = "ASYNC" ]]; then
93-
export CREATECTFDICT=1
94+
export CREATECTFDICT=0
9495
export GPUTYPE=CPU
9596
export SYNCMODE=0
9697
export HOSTMEMSIZE=$TPCTRACKERSCRATCHMEMORY
@@ -103,14 +104,14 @@ for STAGE in $STAGES; do
103104
export HOSTMEMSIZE=$TPCTRACKERSCRATCHMEMORY
104105
export CTFINPUT=0
105106
export SAVECTF=1
106-
rm -f ctf_dictionary.root
107+
JOBUTILS_JOB_SKIPCREATEDONE=1 taskwrapper ${logfile} "rm -f ctf_dictionary.root"
108+
unset JOBUTILS_JOB_SKIPCREATEDONE
107109
fi
108110
export SHMSIZE
109111
export NTIMEFRAMES
110112
export TFDELAY
111113
export GLOBALDPLOPT
112114

113-
logfile=reco_${STAGE}.log
114115
taskwrapper ${logfile} "$O2_ROOT/prodtests/full-system-test/dpl-workflow.sh"
115116

116117
# --- record interesting metrics to monitor ----

0 commit comments

Comments
 (0)