Files updates following coding guidelines

jackal1-66 · jackal1-66 · commit 784d53200ab5 · 2024-09-27T10:55:27.000+02:00
diff --git a/run/SimExamples/HepMC_EPOS4/README.md b/run/SimExamples/HepMC_EPOS4/README.md
@@ -2,46 +2,47 @@
 \page refrunSimExamplesHepMC_EPOS4 Example HepMC_EPOS4
 /doxy -->
 
-The usage of EPOS4 with the O2 machinery is presented in this short manual. 
+The usage of EPOS4 with the O2 machinery is presented in this short manual.
 An in-depth explanation of the mechanisms behind the HepMC(3) data handling can be found in the 
-HepMC_fifo folder of the MC examples.  
-The scripts use the `cmd` parameter of `GeneratorHepMC` to spawn the EPOS4 generation
-via the `epos.sh` script.  
+HepMC_fifo folder of the MC examples. The scripts use the `cmd` parameter of `GeneratorHepMC` 
+to spawn the EPOS4 generation via the `epos.sh` script.
+
 EPOS4 uses the outdated HepMC2 libraries, so this had to be specified in the steering scripts
-of the generators configuration. If `HepMC.version=2` is removed then the scripts will not work 
-anymore. This is to say that the balance achieved with the configurations provided is easily 
-destroyed if the user base edits parts that are not understood completely. 
+of the generators configuration. If `HepMC.version=2` is removed then the scripts will not work
+anymore. This is to say that the balance achieved with the configurations provided is easily
+destroyed if the user base edits parts that are not understood completely.
 
 # Scripts description
 
 Four scripts are available to run the simulations
-- **epos.sh** &rarr; starts the actual EPOS4 generation 
+- **epos.sh** &rarr; starts the actual EPOS4 generation
 - **runo2sim.sh** &rarr; allows the generation of events using o2-sim
 - **rundpg.sh** &rarr; starts the DPG machinery for event generation
 - **rundpl.sh** &rarr; starts the event generation with DPL
 
-In addition an example.optns file is provided to start EPOS4, but more can be found in the generator example folder 
-or in the website [epos4learn.web.cern.ch](https://epos4learn.docs.cern.ch/) where an extensive tutorial on the generator is provided. 
+In addition an example.optns file is provided to start EPOS4, but more can be found in the generator example folder
+or in the website [epos4learn.web.cern.ch](https://epos4learn.docs.cern.ch/) where an extensive tutorial on the generator is provided.
 
 ## epos.sh
 
-It can be run without the help of the other scripts to simply generate an .hepmc file or print 
+It can be run without the help of the other scripts to simply generate an .hepmc file or print
 to the stdout the HepMC results. It it worth nothing though that EPOS4 must be loaded (via cvmfs through AliGenerators or O2sim for example) or installed. In this case the user should simply redirect the stdout to a file:
 ```
 ./epos.sh -i test -s 234345 > test.hepmc
 ```
 This example shows all the functionalities of the script (which are implemented in a similar way inside
-the generation steering scripts). In particular the `-i` flag allows to provide .optns parameters to EPOS4, 
-`-s` feeds the generator with a user seed, and the HepMC output is given by test.hepmc by redirecting the 
-stdout which will contain only the HepMC data thanks to the `-hepstd` flag set automatically in epos.sh and 
-the `set ihepmc 2` option which **MUST** be set in the option file (otherwise either an hepmc file will be created - ihepmc 1 - or nothing will be generated - missing ihepmc or != 1|2 ). 
-It is important to note that setting an empty/null seed in the generator out of the box makes EPOS4 crash, so a protection was added in our steering epos.sh script which now generates a random number if 0 is provided. 
+the generation steering scripts). In particular the `-i` flag allows to provide .optns parameters to EPOS4,
+`-s` feeds the generator with a user seed, and the HepMC output is given by test.hepmc by redirecting the
+stdout which will contain only the HepMC data thanks to the `-hepstd` flag set automatically in epos.sh and
+the `set ihepmc 2` option which **MUST** be set in the option file (otherwise either an hepmc file will be created - ihepmc 1 - or nothing will be generated - missing ihepmc or != 1|2 ).
+
+It is important to note that setting an empty/null seed in the generator out of the box makes EPOS4 crash, so a protection was added in our steering epos.sh script which now generates a random number if 0 is provided.
 
 ## runo2sim.sh, rundpg.sh and rundpl.sh
 
-The three scripts have little differences (especially in the first part), so they will be described together.  
-They work after loading any O2sim version after the 20/09/2024 (included), since multiple modifications had to be performed on both EPOS4 and the introduction of AliGenO2 in order to be able to load both O2sim and EPOS4 simultaneously. 
-If no parameters are provided to the scripts, they will run with default values (energy and nevents provided in the example.optns file), but few flags are available to change the settings of the generation: 
+The three scripts have little differences (especially in the first part), so they will be described together. They work after loading any O2sim version after the 20/09/2024 (included), since multiple modifications had to be performed on both EPOS4 and the introduction of AliGenO2 in order to be able to load both O2sim and EPOS4 simultaneously.
+
+If no parameters are provided to the scripts, they will run with default values (energy and nevents provided in the example.optns file), but few flags are available to change the settings of the generation:
 - **-m , --more** &rarr; feeds the simulation with advanced parameters provided to the configuration key flags
 - **-n , --nevents** &rarr; changes the number of events in the .optns file or gets the one in the file if no events are provided
 - **-i , --input** &rarr; .optns filename to feed EPOS4, no extension must be set in the filename
@@ -50,18 +51,18 @@ If no parameters are provided to the scripts, they will run with default values
 - **-e , --ecm** &rarr; sets the center-of-mass energy in the options file
 
 In the `rundpg.sh` script an additional flag is available
-- **-t , --tf** &rarr; number of timeframes to be generated  
+- **-t , --tf** &rarr; number of timeframes to be generated
 
 In this case the options file will be copied in each tf$n folder, otherwise the epos script won't be able to run with multiple timeframes.  
-In o2sim and DPG scripts the randomly generated seed is set directly, instead this is not feasible with the DPL one, given that the --seed option is not able 
-to redirect this number to GeneratorHepMC. So a seed 0 is automatically given to epos.sh which generates a random number in return.  
+In o2sim and DPG scripts the randomly generated seed is set directly, instead this is not feasible with the DPL one, given that the --seed option is not able to redirect this number to GeneratorHepMC. So a seed 0 is automatically given to epos.sh which generates a random number in return.
+
 Now the three scripts start to differ:
 
 - **runo2sim.sh** &rarr; o2-sim is launched
 - **rundpg.sh** &rarr; first the o2dpg_sim_workflow.py script will be launched generating the json configuration, then the o2_dpg_workflow_runner.py script will start the workflow
 - **rundpl.sh** &rarr; o2-sim-dpl-eventgen is executed piping its results to o2-sim-mctracks-to-aod and afterwards to o2-analysis-mctracks-to-aod-simple-task
 
 The last few lines of the scripts contain the execution of o2-sim, DPG worflow creator/runner and DPL software respectively, so this part can be modified by the users following their requirements. It's important not to delete from the configuration keys `GeneratorFileOrCmd.cmd=$cmd -i $optns;GeneratorFileOrCmd.bMaxSwitch=none;HepMC.version=2;` 
-and it would be better to provide additional configurations via the -m flag. EPOS4 cannot set a maximum impact parameter value, so it's better to leave the bMaxSwitch to none, while the others serve the sole purpose of running successfully the generator using auto generated FIFOs. 
+and it would be better to provide additional configurations via the -m flag. EPOS4 cannot set a maximum impact parameter value, so it's better to leave the bMaxSwitch to none, while the others serve the sole purpose of running successfully the generator using auto generated FIFOs.
 
 
diff --git a/run/SimExamples/HepMC_EPOS4/epos.sh b/run/SimExamples/HepMC_EPOS4/epos.sh
@@ -1,17 +1,17 @@
 #!/bin/sh
-# Script based on CRMC example 
+# Script based on CRMC example
 # EPOS4 option files must contain ihepmc set to 2 to print HepMC
-# data on stdout. -hepmc flag is not needed anymore, but -hepstd is fundamental 
+# data on stdout. -hepmc flag is not needed anymore, but -hepstd is fundamental
 # in order not to print useless information on stdout (a z-*optns*.mtr file will be created)
 
 optns="example"
 seed=$RANDOM
 
 while test $# -gt 0 ; do
     case $1 in
-        -i|--input)   optns=$2 ; shift ;;
-	    -s|--seed)    seed=$2 ; shift ;;
-        -h|--help) usage; exit 0 ;;
+		-i|--input)   optns=$2 ; shift ;;
+		-s|--seed)    seed=$2 ; shift ;;
+		-h|--help) usage; exit 0 ;;
     esac
     shift
 done
diff --git a/run/SimExamples/HepMC_EPOS4/example.optns b/run/SimExamples/HepMC_EPOS4/example.optns
@@ -6,27 +6,27 @@
 !            Define run
 !---------------------------------------
 
-application hadron !hadron-hadron, hadron-nucleus, or nucleus-nucleus                                                 
+application hadron !hadron-hadron, hadron-nucleus, or nucleus-nucleus
 set laproj 1 !projectile atomic number
 set maproj 1 !projectile mass number
 set latarg 1 !target atomic number
 set matarg 1 !target mass number
 set ecms 7000 !sqrt(s)_pp
-set istmax 25 !max status considered for storage 
+set istmax 25 !max status considered for storage
 
 ftime on     !string formation time non-zero
-!suppressed decays: 
-nodecays 
- 110 20 2130 -2130 2230 -2230 1130 -1130 1330 -1330 2330 -2330 3331 -3331 
+!suppressed decays:
+nodecays
+ 110 20 2130 -2130 2230 -2230 1130 -1130 1330 -1330 2330 -2330 3331 -3331
 end
 
 set ninicon 1            !number of initial conditions used for hydro evolution
 core off                 !core/corona not activated
 hydro off                !hydro not activated
 eos off                  !eos not activated
-hacas off                !hadronic cascade not activated  
-set nfreeze 1            !number of freeze out events per hydro event 
+hacas off                !hadronic cascade not activated
+set nfreeze 1            !number of freeze out events per hydro event
 set modsho 1             !printout every modsho events
-set centrality 0         !0=min bias 
+set centrality 0         !0=min bias
 set ihepmc 2             !HepMC output enabled on stdout
 set nfull 10
diff --git a/run/SimExamples/HepMC_EPOS4/rundpg.sh b/run/SimExamples/HepMC_EPOS4/rundpg.sh
@@ -36,7 +36,7 @@ Options:
   -i,--input   INPUT       Options file fed to EPOS4 ($optns)
   -j,--jobs    JOBS        Number of jobs ($JOBS)
   -h,--help                Print these instructions
-  -e,--ecm     ENERGY      Center-of-Mass energy 
+  -e,--ecm     ENERGY      Center-of-Mass energy
   -t,--tf      TF          Timeframes ($TF)
   --                       Rest of command line sent to o2-sim
 
@@ -58,7 +58,7 @@ while test $# -gt 0 ; do
         -n|--nevents) NEV=$2 ; shift ;;
         -i|--input)   optns=$2 ; shift ;;
         -j|--jobs)    JOBS=$2 ; shift ;;
-	    -e|--ecm)     eCM=$2 ; shift ;;
+		-e|--ecm)     eCM=$2 ; shift ;;
         -h|--help) usage; ${O2DPG_ROOT}/MC/bin/o2dpg_sim_workflow.py --help  ; exit 0 ;;
         -t|--tf)     TF=$2 ; shift ;;
         --)           shift ; break ;;
@@ -92,7 +92,7 @@ else
     else
         echo "Error: Number of events not set in EPOS4"
         exit 5
-    fi    
+    fi
 fi
 
 # Set ECM
@@ -126,7 +126,7 @@ done
 # create workflow
 
 ${O2DPG_ROOT}/MC/bin/o2dpg_sim_workflow.py -eCM $eCM -ns $NEV -gen hepmc -tf $TF -j $JOBS \
-					   -interactionRate 500000 -confKey "GeneratorFileOrCmd.cmd=$cmd -i $optns;GeneratorFileOrCmd.bMaxSwitch=none;HepMC.version=2;${more}"
+		-interactionRate 500000 -confKey "GeneratorFileOrCmd.cmd=$cmd -i $optns;GeneratorFileOrCmd.bMaxSwitch=none;HepMC.version=2;${more}"
 
-# Run workflow 
+# Run workflow
 ${O2DPG_ROOT}/MC/bin/o2_dpg_workflow_runner.py -f workflow.json -tt aod --stdout-on-failure
diff --git a/run/SimExamples/HepMC_EPOS4/rundpl.sh b/run/SimExamples/HepMC_EPOS4/rundpl.sh
@@ -1,13 +1,12 @@
 #!/usr/bin/env bash
 #
-# This is a simple simulation example showing how to 
-
+# This is a simple simulation example showing how to
 # start EPOS4 generation automatically using cmd with hepmc output on FIFO
 # and simultaneosly use o2-sim for transport
 
 # This script works only with O2sim version starting from the 20/09/2024
 
-# EPOS4 and O2 must be loaded 
+# EPOS4 and O2 must be loaded
 set -x
 if [ ! "${EPOS4_ROOT}" ]; then
     echo "This needs EPOS4 loaded; alienv enter ..."
@@ -34,7 +33,7 @@ Options:
   -n,--nevents EVENTS      Number of events ($nev)
   -i,--input   INPUT       Options file fed to EPOS4 ($optns)
   -j,--jobs    JOBS        Number of jobs ($JOBS)
-  -e,--ecm     ENERGY      Center-of-Mass energy 
+  -e,--ecm     ENERGY      Center-of-Mass energy
   -h,--help                Print these instructions
   --                       Rest of command line sent to o2-sim
 
@@ -89,7 +88,7 @@ else
     else
         echo "Error: Number of events not set in EPOS4"
         exit 5
-    fi    
+    fi
 fi
 
 # Set ECM
@@ -113,7 +112,7 @@ else
 fi
 
 # Starting simulation => seed is fed automatically to epos with the --seed flag. HepMC.version = 2 is mandatory
-# otherwise the simulation won't work. 
+# otherwise the simulation won't work.
 # Seed is automatically set to Random by the epos.sh script because the --seed option with o2-sim-dpl-eventgen does not feed the number to GeneratorHepMC
 
 o2-sim-dpl-eventgen -b --nEvents ${NEV} --generator hepmc --configKeyValues "GeneratorFileOrCmd.cmd=$cmd -i $optns;GeneratorFileOrCmd.bMaxSwitch=none;HepMC.version=2;${more}" |\
diff --git a/run/SimExamples/HepMC_EPOS4/runo2sim.sh b/run/SimExamples/HepMC_EPOS4/runo2sim.sh
@@ -1,13 +1,12 @@
 #!/usr/bin/env bash
 #
-# This is a simple simulation example showing how to 
-
+# This is a simple simulation example showing how to
 # start EPOS4 generation automatically using cmd with hepmc output on FIFO
 # and simultaneosly use o2-sim for transport
 
 # This script works only with O2sim version starting from the 20/09/2024
 
-# EPOS4 and O2 must be loaded 
+# EPOS4 and O2 must be loaded
 set -x
 if [ ! "${EPOS4_ROOT}" ]; then
     echo "This needs EPOS4 loaded; alienv enter ..."
@@ -34,7 +33,7 @@ Options:
   -n,--nevents EVENTS      Number of events ($nev)
   -i,--input   INPUT       Options file fed to EPOS4 ($optns)
   -j,--jobs    JOBS        Number of jobs ($JOBS)
-  -e,--ecm     ENERGY      Center-of-Mass energy 
+  -e,--ecm     ENERGY      Center-of-Mass energy
   -h,--help                Print these instructions
   --                       Rest of command line sent to o2-sim
 
@@ -89,7 +88,7 @@ else
     else
         echo "Error: Number of events not set in EPOS4"
         exit 5
-    fi    
+    fi
 fi
 
 # Set ECM
