Avoid OOB access

ktf · ktf · commit 7594f93cf273 · 2022-07-02T10:56:03.000+02:00
diff --git a/Detectors/PHOS/reconstruction/src/CaloRawFitter.cxx b/Detectors/PHOS/reconstruction/src/CaloRawFitter.cxx
@@ -143,7 +143,7 @@ CaloRawFitter::FitStatus CaloRawFitter::evalKLevel(gsl::span<short unsigned int>
   // Find index posK (kLevel is a level of "timestamp" point Tk):
   int posK = sigLength - 1; //last point before crossing k-level
   float levelK = pedestal + kAmp * mAmp;
-  while (signal[posK] <= levelK && posK >= 0) {
+  while (posK >= 0 && signal[posK] <= levelK) {
     posK--;
   }
   posK++;

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ CaloRawFitter::FitStatus CaloRawFitter::evalKLevel(gsl::span<short unsigned int>`
`143`	`143`	`// Find index posK (kLevel is a level of "timestamp" point Tk):`
`144`	`144`	`int posK = sigLength - 1; //last point before crossing k-level`
`145`	`145`	`float levelK = pedestal + kAmp * mAmp;`
`146`		`- while (signal[posK] <= levelK && posK >= 0) {`
	`146`	`+ while (posK >= 0 && signal[posK] <= levelK) {`
`147`	`147`	`posK--;`
`148`	`148`	`}`
`149`	`149`	`posK++;`