DPL GUI: avoid misbehavior when % is passed in string (#3905)

ktf · web-flow · commit 75836f4163b2 · 2020-06-28T13:54:10.000+02:00
Render it unformatted in case that's the case.
diff --git a/Framework/Core/src/FrameworkGUIDebugger.cxx b/Framework/Core/src/FrameworkGUIDebugger.cxx
@@ -145,7 +145,11 @@ void displayHistory(const DeviceInfo& info, DeviceControl& control)
       // stream, a second time at display time, to avoid
       // showing unrelevant messages from past.
       if (logLevel >= control.logLevel) {
-        ImGui::TextColored(color, line.c_str(), line.c_str() + line.size());
+        if (line.find('%', 0) == std::string::npos) {
+          ImGui::TextUnformatted(line.c_str(), line.c_str() + line.size());
+        } else {
+          ImGui::TextColored(color, line.c_str(), line.c_str() + line.size());
+        }
       }
     }
     ji = (ji + 1) % historySize;

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,11 @@ void displayHistory(const DeviceInfo& info, DeviceControl& control)`
`145`	`145`	`// stream, a second time at display time, to avoid`
`146`	`146`	`// showing unrelevant messages from past.`
`147`	`147`	`if (logLevel >= control.logLevel) {`
`148`		`- ImGui::TextColored(color, line.c_str(), line.c_str() + line.size());`
	`148`	`+ if (line.find('%', 0) == std::string::npos) {`
	`149`	`+ ImGui::TextUnformatted(line.c_str(), line.c_str() + line.size());`
	`150`	`+ } else {`
	`151`	`+ ImGui::TextColored(color, line.c_str(), line.c_str() + line.size());`
	`152`	`+ }`
`149`	`153`	`}`
`150`	`154`	`}`
`151`	`155`	`ji = (ji + 1) % historySize;`