TPC: Add boundary check for histogram filling

matthias-kleiner · davidrohr · commit 7194b307e63c · 2023-05-24T11:38:09.000+02:00
diff --git a/Detectors/TPC/calibration/include/TPCCalibration/FastHisto.h b/Detectors/TPC/calibration/include/TPCCalibration/FastHisto.h
@@ -175,7 +175,7 @@ template <class T>
 inline void FastHisto<T>::fill(const float val, T weight)
 {
   const int indexBin = findBin(val);
-  if (indexBin == -1) { // if no underflow/overflow bin is used, but the value should be in the underflow/overflow bin return
+  if ((indexBin < 0) || (indexBin > static_cast<int>(mBinCont.size()) - 1)) { // if no underflow/overflow bin is used, but the value should be in the underflow/overflow bin return
     return;
   }
   fillBin(indexBin, weight); // fill the correct index with given weight

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ template <class T>`
`175`	`175`	`inline void FastHisto<T>::fill(const float val, T weight)`
`176`	`176`	`{`
`177`	`177`	`const int indexBin = findBin(val);`
`178`		`- if (indexBin == -1) { // if no underflow/overflow bin is used, but the value should be in the underflow/overflow bin return`
	`178`	`+ if ((indexBin < 0) \|\| (indexBin > static_cast<int>(mBinCont.size()) - 1)) { // if no underflow/overflow bin is used, but the value should be in the underflow/overflow bin return`
`179`	`179`	`return;`
`180`	`180`	`}`
`181`	`181`	`fillBin(indexBin, weight); // fill the correct index with given weight`