Skip to content

Commit 6542611

Browse files
davidrohrdavidrohr
committed
Fix new codechecker errors from clang10
1 parent ddd815e commit 6542611

33 files changed

Lines changed: 86 additions & 64 deletions

File tree

‎DataFormats/Detectors/EMCAL/include/DataFormatsEMCAL/AnalysisCluster.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class AnalysisCluster
3939
/// \class CellOutOfRangeException
4040
/// \brief Exception handling non-existing cell indices
4141
/// \ingroup EMCALbase
42-
class CellOutOfRangeException : public std::exception
42+
class CellOutOfRangeException final : public std::exception
4343
{
4444
public:
4545
/// \brief Constructor, setting cell wrong cell index raising the exception

‎DataFormats/Detectors/EMCAL/include/DataFormatsEMCAL/Constants.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ enum ChannelType_t {
3838

3939
/// \class InvalidChanneltypeException
4040
/// \brief Error handling invalid channel types
41-
class InvalidChanneltypeException : public std::exception
41+
class InvalidChanneltypeException final : public std::exception
4242
{
4343
public:
4444
/// \brief Constructor initializing the exception

‎DataFormats/Detectors/EMCAL/include/DataFormatsEMCAL/EventHandler.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class EventHandler
8888

8989
/// \class RangeException
9090
/// \brief Exception handling errors due to exceeding the range of triggers handled by the handler
91-
class RangeException : public std::exception
91+
class RangeException final : public std::exception
9292
{
9393
public:
9494
/// \brief Constructor defining the error
@@ -125,7 +125,7 @@ class EventHandler
125125

126126
/// \class NotInitializedException
127127
/// \brief Exception handling unitialized event handler
128-
class NotInitializedException : public std::exception
128+
class NotInitializedException final : public std::exception
129129
{
130130
public:
131131
/// \brief Constructor initializing the exception
@@ -141,7 +141,7 @@ class EventHandler
141141

142142
/// \class InteractionRecordInvalidException
143143
/// \brief Error handling in case the interaction records from various sources do not match
144-
class InteractionRecordInvalidException : public std::exception
144+
class InteractionRecordInvalidException final : public std::exception
145145
{
146146
public:
147147
/// \brief Constructor initializing the exception

‎Detectors/CPV/simulation/include/CPVSimulation/GeometryParams.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace o2
2121
{
2222
namespace cpv
2323
{
24-
class GeometryParams : public TNamed
24+
class GeometryParams final : public TNamed
2525
{
2626
public:
2727
/// Default constructor

‎Detectors/EMCAL/base/include/EMCALBase/ClusterFactory.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class ClusterFactory
3838
{
3939

4040
public:
41-
class ClusterRangeException : public std::exception
41+
class ClusterRangeException final : public std::exception
4242
{
4343
public:
4444
/// \brief Constructor defining the error
@@ -73,7 +73,7 @@ class ClusterFactory
7373
std::string mErrorMessage; ///< Error message
7474
};
7575

76-
class CellIndexRangeException : public std::exception
76+
class CellIndexRangeException final : public std::exception
7777
{
7878
public:
7979
/// \brief Constructor defining the error

‎Detectors/EMCAL/base/include/EMCALBase/GeometryBase.h‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const std::string DEFAULT_GEOMETRY = "EMCAL_COMPLETE12SMV1_DCAL_8SM";
3535
/// \class InvalidModuleException
3636
/// \brief Error Handling when an invalid module ID (outside the limits) is called
3737
/// \ingroup EMCALbase
38-
class InvalidModuleException : public std::exception
38+
class InvalidModuleException final : public std::exception
3939
{
4040
public:
4141
/// \brief Constructor
@@ -72,7 +72,7 @@ class InvalidModuleException : public std::exception
7272
/// \class InvalidPositionException
7373
/// \brief Exception handling errors due to positions not in the EMCAL area
7474
/// \ingroup EMCALbase
75-
class InvalidPositionException : public std::exception
75+
class InvalidPositionException final : public std::exception
7676
{
7777
public:
7878
/// \brief Constructor, setting the position raising the exception
@@ -109,7 +109,7 @@ class InvalidPositionException : public std::exception
109109
/// \class InvalidCellIDException
110110
/// \brief Exception handling non-existing cell IDs
111111
/// \ingroup EMCALbase
112-
class InvalidCellIDException : public std::exception
112+
class InvalidCellIDException final : public std::exception
113113
{
114114
public:
115115
/// \brief Constructor, setting cell ID raising the exception
@@ -139,7 +139,7 @@ class InvalidCellIDException : public std::exception
139139
/// \class InvalidSupermoduleTypeException
140140
/// \brief Exception handling improper or uninitialized supermodule types
141141
/// \ingroup EMCALbase
142-
class InvalidSupermoduleTypeException : public std::exception
142+
class InvalidSupermoduleTypeException final : public std::exception
143143
{
144144
public:
145145
/// \brief constructor
@@ -155,7 +155,7 @@ class InvalidSupermoduleTypeException : public std::exception
155155
/// \class SupermoduleIndexException
156156
/// \brief Handling error due to invalid supermodule
157157
/// \ingroup EMCALbase
158-
class SupermoduleIndexException : public std::exception
158+
class SupermoduleIndexException final : public std::exception
159159
{
160160
public:
161161
/// \brief Constructor, initializing the exception
@@ -192,7 +192,7 @@ class SupermoduleIndexException : public std::exception
192192
/// \class RowColException
193193
/// \brief Handling error for invalid positions in row-column space
194194
/// \ingroup EMCALBase
195-
class RowColException : public std::exception
195+
class RowColException final : public std::exception
196196
{
197197
public:
198198
/// \brief Constructor, initializing the exception with invalid row-column position

‎Detectors/EMCAL/base/include/EMCALBase/Mapper.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ class MappingHandler
306306
///
307307
/// Error thrown in queries to the MappingHandler where the DDL ID is
308308
/// out-of-range for EMCAL.
309-
class DDLInvalid : public std::exception
309+
class DDLInvalid final : public std::exception
310310
{
311311
public:
312312
DDLInvalid(int ddlID) : mDDL(ddlID) { mMessage = fmt::format("DDL {0} not existing for EMCAL", mDDL); };

‎Detectors/EMCAL/calib/include/EMCALCalib/CalibDB.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class CalibDB
6565
/// - Incorrect path
6666
/// - Wrong timestamp
6767
/// - Meta data not set
68-
class ObjectNotFoundException : public std::exception
68+
class ObjectNotFoundException final : public std::exception
6969
{
7070
public:
7171
/// \brief Constructor with query parameters
@@ -123,7 +123,7 @@ class CalibDB
123123
/// a certain path and with a certain timestamp was valid, the object
124124
/// however has a different type than the expected one (something was
125125
/// screwed up when writing to the CCDB)
126-
class TypeMismatchException : public std::exception
126+
class TypeMismatchException final : public std::exception
127127
{
128128
public:
129129
/// \brief Constructor

‎Detectors/EMCAL/reconstruction/include/EMCALReconstruction/CaloRawFitterGamma2.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ namespace emcal
3737
/// Newton's method used for solving the set of non-linear equations.
3838
/// Ported from class AliCaloRawAnalyzerGamma2 from AliRoot
3939

40-
class CaloRawFitterGamma2 : public CaloRawFitter
40+
class CaloRawFitterGamma2 final : public CaloRawFitter
4141
{
4242

4343
public:

‎Detectors/EMCAL/reconstruction/include/EMCALReconstruction/CaloRawFitterStandard.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ namespace emcal
3939
/// least square fit for the
4040
/// Moment assuming identical and
4141
/// independent errors (equivalent with chi square)
42-
class CaloRawFitterStandard : public CaloRawFitter
42+
class CaloRawFitterStandard final : public CaloRawFitter
4343
{
4444

4545
public:

0 commit comments

Comments
 (0)