fix dispatch

aalkin · aalkin · commit 49b27f7cf62f · 2021-07-31T08:40:41.000+02:00
diff --git a/Framework/Core/include/Framework/AnalysisManagers.h b/Framework/Core/include/Framework/AnalysisManagers.h
@@ -362,7 +362,7 @@ template <typename T>
 struct ServiceManager<Service<T>> {
   static bool add(std::vector<ServiceSpec>& specs, Service<T>&)
   {
-    specs.push_back(CommonAnalysisServices::addAnalysisService<T>());
+    CommonAnalysisServices::addAnalysisService<T>(specs);
     return true;
   }
 
diff --git a/Framework/Core/include/Framework/CommonServices.h b/Framework/Core/include/Framework/CommonServices.h
@@ -14,6 +14,8 @@
 #include "Framework/ServiceSpec.h"
 #include "Framework/TypeIdHelpers.h"
 
+class TDatabasePDG;
+
 namespace o2::framework
 {
 
@@ -73,7 +75,12 @@ struct CommonAnalysisServices {
   static ServiceSpec databasePDGSpec();
 
   template <typename T>
-  static ServiceSpec addAnalysisService();
+  static void addAnalysisService(std::vector<ServiceSpec>& specs)
+  {
+    if constexpr (std::is_same_v<T, TDatabasePDG>) {
+      specs.push_back(databasePDGSpec());
+    }
+  }
 };
 
 } // namespace o2::framework
diff --git a/Framework/Core/src/CommonServices.cxx b/Framework/Core/src/CommonServices.cxx
@@ -542,12 +542,5 @@ o2::framework::ServiceSpec CommonAnalysisServices::databasePDGSpec()
     .exit = [](ServiceRegistry&, void* service) { reinterpret_cast<TDatabasePDG*>(service)->Delete(); },
     .kind = ServiceKind::Serial};
 }
-
-template <>
-o2::framework::ServiceSpec CommonAnalysisServices::addAnalysisService<TDatabasePDG>()
-{
-  return databasePDGSpec();
-}
-
 } // namespace o2::framework
 #pragma GCC diagnostic pop

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,7 @@ template <typename T>`
`362`	`362`	`struct ServiceManager<Service<T>> {`
`363`	`363`	`static bool add(std::vector<ServiceSpec>& specs, Service<T>&)`
`364`	`364`	`{`
`365`		`- specs.push_back(CommonAnalysisServices::addAnalysisService<T>());`
	`365`	`+ CommonAnalysisServices::addAnalysisService<T>(specs);`
`366`	`366`	`return true;`
`367`	`367`	`}`
`368`	`368`