TRD: Base: Fix possible segfault

f3sch · f3sch · commit 36630d23b620 · 2023-02-16T17:39:29.000+01:00
Returning -1 here leads to overflow indexing in mData, which is a
possbile segfault.
Just warning and returning 0 is safe enough here.

Signed-off-by: Felix Schlepper &lt;f3sch.git@outlook.com&gt;
diff --git a/Detectors/TRD/base/include/TRDBase/PadParameters.h b/Detectors/TRD/base/include/TRDBase/PadParameters.h
@@ -74,10 +74,10 @@ int PadParameters<T>::getChannel(int col, int row) const
     return row + col * constants::NROWC0;
   } else if (mData.size() == constants::NROWC1 * constants::NCOLUMN) {
     return row + col * constants::NROWC1;
-  } else {
-    LOG(error) << "Wrong number of channels set: " << mData.size();
   }
-  return -1;
+
+  LOG(error) << "Wrong number of channels set: " << mData.size();
+  return 0;
 }
 
 } // namespace trd

Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,10 @@ int PadParameters<T>::getChannel(int col, int row) const`
`74`	`74`	`return row + col * constants::NROWC0;`
`75`	`75`	`} else if (mData.size() == constants::NROWC1 * constants::NCOLUMN) {`
`76`	`76`	`return row + col * constants::NROWC1;`
`77`		`- } else {`
`78`		`- LOG(error) << "Wrong number of channels set: " << mData.size();`
`79`	`77`	`}`
`80`		`- return -1;`
	`78`	`+`
	`79`	`+ LOG(error) << "Wrong number of channels set: " << mData.size();`
	`80`	`+ return 0;`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`} // namespace trd`