Skip to content

Commit 2db8ab9

Browse files
shahor02shahor02
committed
downgrade logs: ALARM->WARN, IMPORTANT->INFO
1 parent ca3ea37 commit 2db8ab9

5 files changed

Lines changed: 43 additions & 43 deletions

File tree

‎Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/RawPixelReader.h‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -768,9 +768,9 @@ class RawPixelReader : public PixelReader
768768
#ifdef _RAW_READER_ERROR_CHECKS_
769769
if (RDHUtils::getPacketCounter(rdh) > ruLink->packetCounter + 1) {
770770
ruLinkStat.errorCounts[GBTLinkDecodingStat::ErrPacketCounterJump]++;
771-
LOG(alarm) << ruLinkStat.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
772-
<< " : FEEId:" << OUTHEX(RDHUtils::getFEEID(rdh), 4) << ": jump from " << int(ruLink->packetCounter)
773-
<< " to " << int(RDHUtils::getPacketCounter(rdh));
771+
LOG(warn) << ruLinkStat.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
772+
<< " : FEEId:" << OUTHEX(RDHUtils::getFEEID(rdh), 4) << ": jump from " << int(ruLink->packetCounter)
773+
<< " to " << int(RDHUtils::getPacketCounter(rdh));
774774
RDHUtils::printRDH(rdh);
775775
}
776776
#endif
@@ -1036,9 +1036,9 @@ class RawPixelReader : public PixelReader
10361036
#ifdef _RAW_READER_ERROR_CHECKS_
10371037
if (RDHUtils::getPacketCounter(rdh) > ruLink->packetCounter + 1) {
10381038
ruLinkStat.errorCounts[GBTLinkDecodingStat::ErrPacketCounterJump]++;
1039-
LOG(alarm) << ruLinkStat.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
1040-
<< " : FEEId:" << OUTHEX(RDHUtils::getFEEID(rdh), 4) << ": jump from " << int(ruLink->packetCounter)
1041-
<< " to " << int(RDHUtils::getPacketCounter(rdh));
1039+
LOG(warn) << ruLinkStat.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
1040+
<< " : FEEId:" << OUTHEX(RDHUtils::getFEEID(rdh), 4) << ": jump from " << int(ruLink->packetCounter)
1041+
<< " to " << int(RDHUtils::getPacketCounter(rdh));
10421042
RDHUtils::printRDH(rdh);
10431043
}
10441044
#endif

‎Detectors/ITSMFT/common/reconstruction/src/Clusterer.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ void Clusterer::ClustererThread::finishChip(ChipPixelData* curChipData, CompClus
246246
} else {
247247
auto warnLeft = MaxHugeClusWarn - parent->mNHugeClus;
248248
if (warnLeft > 0) {
249-
LOGP(alarm, "Splitting a huge cluster: chipID {}, rows {}:{} cols {}:{}{}", bbox.chipID, bbox.rowMin, bbox.rowMax, bbox.colMin, bbox.colMax,
249+
LOGP(warn, "Splitting a huge cluster: chipID {}, rows {}:{} cols {}:{}{}", bbox.chipID, bbox.rowMin, bbox.rowMax, bbox.colMin, bbox.colMax,
250250
warnLeft == 1 ? " (Further warnings will be muted)" : "");
251251
#ifdef WITH_OPENMP
252252
#pragma omp critical

‎Detectors/ITSMFT/common/reconstruction/src/DecodingStat.cxx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ uint32_t ChipStat::addErrors(uint32_t mask, uint16_t chID, int verbosity)
4040
if (mask & (0x1 << i)) {
4141
res |= ErrActions[i] & ErrActPropagate;
4242
if (verbosity > -1 && (!errorCounts[i] || verbosity > 1)) {
43-
LOGP(important, "New error registered on the FEEID:{:#04x}: chip#{}: {}", feeID, chID, ErrNames[i]);
43+
LOGP(info, "New error registered on the FEEID:{:#04x}: chip#{}: {}", feeID, chID, ErrNames[i]);
4444
res |= ErrActions[i] & ErrActDump;
4545
}
4646
errorCounts[i]++;
@@ -60,7 +60,7 @@ uint32_t ChipStat::addErrors(const ChipPixelData& d, int verbosity)
6060
if (d.getErrorFlags() & (0x1 << i)) {
6161
res |= ErrActions[i] & ErrActPropagate;
6262
if (verbosity > -1 && (!errorCounts[i] || verbosity > 1)) {
63-
LOGP(important, "New error registered at bc/orbit {}/{} on the FEEID:{:#04x} chip#{}: {}{}",
63+
LOGP(info, "New error registered at bc/orbit {}/{} on the FEEID:{:#04x} chip#{}: {}{}",
6464
d.getInteractionRecord().bc, d.getInteractionRecord().orbit,
6565
feeID, int16_t(d.getChipID()), ErrNames[i], d.getErrorDetails(i));
6666
res |= ErrActions[i] & ErrActDump;
@@ -87,7 +87,7 @@ void ChipStat::print(bool skipNoErr, const std::string& pref) const
8787
rep += fmt::format(" | Err.: {}: {}", ErrNames[i].data(), errorCounts[i]);
8888
}
8989
}
90-
LOG(important) << rep;
90+
LOG(info) << rep;
9191
}
9292
}
9393

@@ -120,6 +120,6 @@ void GBTLinkDecodingStat::print(bool skipNoErr) const
120120
rep += fmt::format(" [{}: {}]", ErrNames[i].data(), errorCounts[i]);
121121
}
122122
}
123-
LOG(important) << rep;
123+
LOG(info) << rep;
124124
}
125125
}

‎Detectors/ITSMFT/common/reconstruction/src/GBTLink.cxx‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -145,16 +145,16 @@ uint8_t GBTLink::checkErrorsRDH(const RDH& rdh)
145145
statistics.errorCounts[GBTLinkDecodingStat::ErrNoRDHAtStart]++;
146146
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrNoRDHAtStart])) {
147147
err |= uint8_t(ErrorPrinted);
148-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrNoRDHAtStart];
148+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrNoRDHAtStart];
149149
}
150150
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrNoRDHAtStart);
151151
err |= uint8_t(Abort);
152152
return err; // fatal error
153153
}
154154
if (format == OldFormat && RDHUtils::getVersion(rdh) > 4) {
155155
if (verbosity >= VerboseErrors) {
156-
LOG(important) << "Requested old format requires data with RDH version 3 or 4, RDH version "
157-
<< RDHUtils::getVersion(rdh) << " is found";
156+
LOG(info) << "Requested old format requires data with RDH version 3 or 4, RDH version "
157+
<< RDHUtils::getVersion(rdh) << " is found";
158158
err |= uint8_t(ErrorPrinted);
159159
}
160160
err |= uint8_t(Abort);
@@ -166,8 +166,8 @@ uint8_t GBTLink::checkErrorsRDH(const RDH& rdh)
166166
}
167167
statistics.errorCounts[GBTLinkDecodingStat::ErrPacketCounterJump]++;
168168
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrPacketCounterJump])) {
169-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
170-
<< " : jump from " << int(packetCounter) << " to " << int(RDHUtils::getPacketCounter(rdh));
169+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
170+
<< " : jump from " << int(packetCounter) << " to " << int(RDHUtils::getPacketCounter(rdh));
171171
err |= uint8_t(ErrorPrinted);
172172
}
173173
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrPacketCounterJump);
@@ -186,7 +186,7 @@ uint8_t GBTLink::checkErrorsRDHStop(const RDH& rdh)
186186
&& !RDHUtils::getStop(*lastRDH)) {
187187
statistics.errorCounts[GBTLinkDecodingStat::ErrPageNotStopped]++;
188188
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrPageNotStopped])) {
189-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrPageNotStopped];
189+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrPageNotStopped];
190190
RDHUtils::printRDH(*lastRDH);
191191
RDHUtils::printRDH(rdh);
192192
err |= uint8_t(ErrorPrinted);
@@ -205,7 +205,7 @@ uint8_t GBTLink::checkErrorsRDHStopPageEmpty(const RDH& rdh)
205205
if (format == NewFormat && RDHUtils::getStop(rdh) && RDHUtils::getMemorySize(rdh) != sizeof(RDH) + sizeof(GBTDiagnostic)) {
206206
statistics.errorCounts[GBTLinkDecodingStat::ErrStopPageNotEmpty]++;
207207
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrStopPageNotEmpty])) {
208-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrStopPageNotEmpty];
208+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrStopPageNotEmpty];
209209
RDHUtils::printRDH(rdh);
210210
err |= uint8_t(ErrorPrinted);
211211
}
@@ -224,7 +224,7 @@ uint8_t GBTLink::checkErrorsTriggerWord(const GBTTrigger* gbtTrg)
224224
statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTTrigger]++;
225225
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTTrigger])) {
226226
gbtTrg->printX();
227-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTTrigger];
227+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTTrigger];
228228
err |= uint8_t(ErrorPrinted);
229229
}
230230
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrMissingGBTTrigger);
@@ -250,7 +250,7 @@ uint8_t GBTLink::checkErrorsHeaderWord(const GBTDataHeader* gbtH)
250250
statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTHeader]++;
251251
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTHeader])) {
252252
gbtH->printX();
253-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTHeader];
253+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTHeader];
254254
err |= uint8_t(ErrorPrinted);
255255
}
256256
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrMissingGBTHeader);
@@ -268,7 +268,7 @@ uint8_t GBTLink::checkErrorsHeaderWord(const GBTDataHeaderL* gbtH)
268268
statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTHeader]++;
269269
if (verbosity >= VerboseErrors) {
270270
gbtH->printX();
271-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTHeader];
271+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTHeader];
272272
err |= uint8_t(ErrorPrinted);
273273
}
274274
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrMissingGBTHeader);
@@ -280,8 +280,8 @@ uint8_t GBTLink::checkErrorsHeaderWord(const GBTDataHeaderL* gbtH)
280280
if (gbtH->packetIdx != cnt) {
281281
statistics.errorCounts[GBTLinkDecodingStat::ErrRDHvsGBTHPageCnt]++;
282282
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrRDHvsGBTHPageCnt])) {
283-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrRDHvsGBTHPageCnt] << ": diff in GBT header "
284-
<< gbtH->packetIdx << " and RDH page " << cnt << " counters";
283+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrRDHvsGBTHPageCnt] << ": diff in GBT header "
284+
<< gbtH->packetIdx << " and RDH page " << cnt << " counters";
285285
err |= uint8_t(ErrorPrinted);
286286
}
287287
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrRDHvsGBTHPageCnt);
@@ -294,8 +294,8 @@ uint8_t GBTLink::checkErrorsHeaderWord(const GBTDataHeaderL* gbtH)
294294
if (gbtH->packetIdx) {
295295
statistics.errorCounts[GBTLinkDecodingStat::ErrNonZeroPageAfterStop]++;
296296
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrNonZeroPageAfterStop])) {
297-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrNonZeroPageAfterStop]
298-
<< ": Non-0 page counter (" << cnt << ") while all lanes were stopped";
297+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrNonZeroPageAfterStop]
298+
<< ": Non-0 page counter (" << cnt << ") while all lanes were stopped";
299299
err |= uint8_t(ErrorPrinted);
300300
}
301301
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrNonZeroPageAfterStop);
@@ -314,8 +314,8 @@ uint8_t GBTLink::checkErrorsActiveLanes(int cbl)
314314
statistics.errorCounts[GBTLinkDecodingStat::ErrInvalidActiveLanes]++;
315315
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrInvalidActiveLanes])) {
316316
std::bitset<32> expectL(cbl), gotL(lanesActive);
317-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrInvalidActiveLanes] << ' '
318-
<< gotL << " vs " << expectL << " skip page";
317+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrInvalidActiveLanes] << ' '
318+
<< gotL << " vs " << expectL << " skip page";
319319
err |= uint8_t(ErrorPrinted);
320320
}
321321
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrInvalidActiveLanes);
@@ -333,7 +333,7 @@ uint8_t GBTLink::checkErrorsGBTData(int cablePos)
333333
if (lanesStop & (0x1 << cablePos)) { // make sure stopped lanes do not transmit the data
334334
statistics.errorCounts[GBTLinkDecodingStat::ErrDataForStoppedLane]++;
335335
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrDataForStoppedLane])) {
336-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrDataForStoppedLane] << cablePos;
336+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrDataForStoppedLane] << cablePos;
337337
err |= uint8_t(ErrorPrinted);
338338
}
339339
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrDataForStoppedLane);
@@ -359,7 +359,7 @@ uint8_t GBTLink::checkErrorsGBTDataID(const GBTData* gbtD)
359359
printCableStatus((GBTCableStatus*)gbtD);
360360
}
361361
gbtD->printX(true);
362-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrGBTWordNotRecognized];
362+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrGBTWordNotRecognized];
363363
err |= uint8_t(ErrorPrinted);
364364
}
365365
err |= uint8_t(Skip);
@@ -375,7 +375,7 @@ uint8_t GBTLink::checkErrorsTrailerWord(const GBTDataTrailer* gbtT)
375375
gbtT->printX();
376376
statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTTrailer]++;
377377
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTTrailer])) {
378-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTTrailer];
378+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTTrailer];
379379
err |= uint8_t(ErrorPrinted);
380380
}
381381
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrMissingGBTTrailer);
@@ -395,7 +395,7 @@ uint8_t GBTLink::checkErrorsPacketDoneMissing(const GBTDataTrailer* gbtT, bool n
395395
if (!gbtT || (!gbtT->packetDone && notEnd)) { // Done may be missing only in case of carry-over to new CRU page
396396
statistics.errorCounts[GBTLinkDecodingStat::ErrPacketDoneMissing]++;
397397
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrPacketDoneMissing])) {
398-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrPacketDoneMissing];
398+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrPacketDoneMissing];
399399
err |= uint8_t(ErrorPrinted);
400400
}
401401
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrPacketDoneMissing);
@@ -415,8 +415,8 @@ uint8_t GBTLink::checkErrorsLanesStops()
415415
statistics.errorCounts[GBTLinkDecodingStat::ErrUnstoppedLanes]++;
416416
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrUnstoppedLanes])) {
417417
std::bitset<32> active(lanesActive), stopped(lanesStop);
418-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrUnstoppedLanes]
419-
<< " | active: " << active << " stopped: " << stopped;
418+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrUnstoppedLanes]
419+
<< " | active: " << active << " stopped: " << stopped;
420420
err |= uint8_t(ErrorPrinted);
421421
}
422422
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrUnstoppedLanes);
@@ -428,8 +428,8 @@ uint8_t GBTLink::checkErrorsLanesStops()
428428
statistics.errorCounts[GBTLinkDecodingStat::ErrNoDataForActiveLane]++;
429429
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrNoDataForActiveLane])) {
430430
std::bitset<32> withData(lanesWithData), active(lanesActive), timeOut(lanesTimeOut);
431-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrNoDataForActiveLane]
432-
<< " | with data: " << withData << " active: " << active << " timeOut: " << timeOut;
431+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrNoDataForActiveLane]
432+
<< " | with data: " << withData << " active: " << active << " timeOut: " << timeOut;
433433
err |= uint8_t(ErrorPrinted);
434434
}
435435
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrNoDataForActiveLane);
@@ -447,7 +447,7 @@ uint8_t GBTLink::checkErrorsDiagnosticWord(const GBTDiagnostic* gbtD)
447447
statistics.errorCounts[GBTLinkDecodingStat::ErrMissingDiagnosticWord]++;
448448
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrMissingDiagnosticWord])) {
449449
gbtD->printX();
450-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingDiagnosticWord];
450+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingDiagnosticWord];
451451
err |= uint8_t(ErrorPrinted);
452452
}
453453
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrMissingDiagnosticWord);
@@ -465,7 +465,7 @@ uint8_t GBTLink::checkErrorsCableID(const GBTData* gbtD, uint8_t cableSW)
465465
statistics.errorCounts[GBTLinkDecodingStat::ErrWrongeCableID]++;
466466
if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrWrongeCableID])) {
467467
gbtD->printX();
468-
LOG(important) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrWrongeCableID] << ' ' << gbtD->getCableID();
468+
LOG(info) << describe() << ' ' << irHBF << ' ' << statistics.ErrNames[GBTLinkDecodingStat::ErrWrongeCableID] << ' ' << gbtD->getCableID();
469469
err |= uint8_t(ErrorPrinted);
470470
}
471471
errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrWrongeCableID);

0 commit comments

Comments
 (0)