Avoid uninitialized values in DataProcessingStats

knopers8 · ktf · commit 0cc053cdc81a · 2024-07-04T09:20:56.000+02:00
Uninitialized std::array of fundamental types has indetermined contents, leading to some noise generated by valgrind. Unless there are performance reasons not to do it, I would propose to use value-initialization to avoid the warnings.
diff --git a/Framework/Core/include/Framework/DataProcessingStats.h b/Framework/Core/include/Framework/DataProcessingStats.h
@@ -170,15 +170,15 @@ struct DataProcessingStats {
 
   void flushChangedMetrics(std::function<void(MetricSpec const&, int64_t, int64_t)> const& callback);
 
-  std::atomic<size_t> statesSize;
+  std::atomic<size_t> statesSize = 0;
 
   std::array<Command, MAX_CMDS> cmds = {};
   std::array<int64_t, MAX_METRICS> metrics = {};
   std::array<bool, MAX_METRICS> updated = {};
-  std::array<std::string, MAX_METRICS> metricsNames;
-  std::array<UpdateInfo, MAX_METRICS> updateInfos;
-  std::array<MetricSpec, MAX_METRICS> metricSpecs;
-  std::array<int64_t, MAX_METRICS> lastPublishedMetrics;
+  std::array<std::string, MAX_METRICS> metricsNames = {};
+  std::array<UpdateInfo, MAX_METRICS> updateInfos = {};
+  std::array<MetricSpec, MAX_METRICS> metricSpecs = {};
+  std::array<int64_t, MAX_METRICS> lastPublishedMetrics = {};
   std::vector<int> availableMetrics;
   // How many commands have been committed to the queue.
   std::atomic<int> insertedCmds = 0;
