forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathlintingEngine.ts
More file actions
210 lines (182 loc) · 9.83 KB
/
lintingEngine.ts
File metadata and controls
210 lines (182 loc) · 9.83 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
'use strict';
import { inject, injectable } from 'inversify';
import { Minimatch } from 'minimatch';
import * as path from 'path';
import * as vscode from 'vscode';
import { IDocumentManager, IWorkspaceService } from '../common/application/types';
import { LinterErrors, STANDARD_OUTPUT_CHANNEL } from '../common/constants';
import { IFileSystem } from '../common/platform/types';
import { IConfigurationService, IOutputChannel } from '../common/types';
import { StopWatch } from '../common/utils/stopWatch';
import { IServiceContainer } from '../ioc/types';
import { JupyterProvider } from '../jupyter/provider';
import { sendTelemetryWhenDone } from '../telemetry';
import { EventName } from '../telemetry/constants';
import { LinterTrigger, LintingTelemetry } from '../telemetry/types';
import { ILinterInfo, ILinterManager, ILintingEngine, ILintMessage, LintMessageSeverity } from './types';
const PYTHON: vscode.DocumentFilter = { language: 'python' };
const lintSeverityToVSSeverity = new Map<LintMessageSeverity, vscode.DiagnosticSeverity>();
lintSeverityToVSSeverity.set(LintMessageSeverity.Error, vscode.DiagnosticSeverity.Error);
lintSeverityToVSSeverity.set(LintMessageSeverity.Hint, vscode.DiagnosticSeverity.Hint);
lintSeverityToVSSeverity.set(LintMessageSeverity.Information, vscode.DiagnosticSeverity.Information);
lintSeverityToVSSeverity.set(LintMessageSeverity.Warning, vscode.DiagnosticSeverity.Warning);
// tslint:disable-next-line:interface-name
interface DocumentHasJupyterCodeCells {
// tslint:disable-next-line:callable-types
(doc: vscode.TextDocument, token: vscode.CancellationToken): Promise<Boolean>;
}
@injectable()
export class LintingEngine implements ILintingEngine {
private documentHasJupyterCodeCells: DocumentHasJupyterCodeCells;
private workspace: IWorkspaceService;
private documents: IDocumentManager;
private configurationService: IConfigurationService;
private linterManager: ILinterManager;
private diagnosticCollection: vscode.DiagnosticCollection;
private pendingLintings = new Map<string, vscode.CancellationTokenSource>();
private outputChannel: vscode.OutputChannel;
private fileSystem: IFileSystem;
constructor(@inject(IServiceContainer) private serviceContainer: IServiceContainer) {
this.documentHasJupyterCodeCells = (_a, _b) => Promise.resolve(false);
this.documents = serviceContainer.get<IDocumentManager>(IDocumentManager);
this.workspace = serviceContainer.get<IWorkspaceService>(IWorkspaceService);
this.configurationService = serviceContainer.get<IConfigurationService>(IConfigurationService);
this.outputChannel = serviceContainer.get<vscode.OutputChannel>(IOutputChannel, STANDARD_OUTPUT_CHANNEL);
this.linterManager = serviceContainer.get<ILinterManager>(ILinterManager);
this.fileSystem = serviceContainer.get<IFileSystem>(IFileSystem);
this.diagnosticCollection = vscode.languages.createDiagnosticCollection('python');
}
public get diagnostics(): vscode.DiagnosticCollection {
return this.diagnosticCollection;
}
public clearDiagnostics(document: vscode.TextDocument): void {
if (this.diagnosticCollection.has(document.uri)) {
this.diagnosticCollection.delete(document.uri);
}
}
public async lintOpenPythonFiles(): Promise<vscode.DiagnosticCollection> {
this.diagnosticCollection.clear();
const promises = this.documents.textDocuments.map(async document => this.lintDocument(document, 'auto'));
await Promise.all(promises);
return this.diagnosticCollection;
}
public async lintDocument(document: vscode.TextDocument, trigger: LinterTrigger): Promise<void> {
this.diagnosticCollection.set(document.uri, []);
// Check if we need to lint this document
if (!await this.shouldLintDocument(document)) {
return;
}
if (this.pendingLintings.has(document.uri.fsPath)) {
this.pendingLintings.get(document.uri.fsPath)!.cancel();
this.pendingLintings.delete(document.uri.fsPath);
}
const cancelToken = new vscode.CancellationTokenSource();
cancelToken.token.onCancellationRequested(() => {
if (this.pendingLintings.has(document.uri.fsPath)) {
this.pendingLintings.delete(document.uri.fsPath);
}
});
this.pendingLintings.set(document.uri.fsPath, cancelToken);
const activeLinters = await this.linterManager.getActiveLinters(false, document.uri);
const promises: Promise<ILintMessage[]>[] = activeLinters
.map(async (info: ILinterInfo) => {
const stopWatch = new StopWatch();
const linter = await this.linterManager.createLinter(
info.product,
this.outputChannel,
this.serviceContainer,
document.uri
);
const promise = linter.lint(document, cancelToken.token);
this.sendLinterRunTelemetry(info, document.uri, promise, stopWatch, trigger);
return promise;
});
const hasJupyterCodeCells = await this.documentHasJupyterCodeCells(document, cancelToken.token);
// linters will resolve asynchronously - keep a track of all
// diagnostics reported as them come in.
let diagnostics: vscode.Diagnostic[] = [];
const settings = this.configurationService.getSettings(document.uri);
for (const p of promises) {
const msgs = await p;
if (cancelToken.token.isCancellationRequested) {
break;
}
if (this.isDocumentOpen(document.uri)) {
// Build the message and suffix the message with the name of the linter used.
for (const m of msgs) {
// Ignore magic commands from jupyter.
if (hasJupyterCodeCells && document.lineAt(m.line - 1).text.trim().startsWith('%') &&
(m.code === LinterErrors.pylint.InvalidSyntax ||
m.code === LinterErrors.prospector.InvalidSyntax ||
m.code === LinterErrors.flake8.InvalidSyntax)) {
continue;
}
diagnostics.push(this.createDiagnostics(m, document));
}
// Limit the number of messages to the max value.
diagnostics = diagnostics.filter((_value, index) => index <= settings.linting.maxNumberOfProblems);
}
}
// Set all diagnostics found in this pass, as this method always clears existing diagnostics.
this.diagnosticCollection.set(document.uri, diagnostics);
}
// tslint:disable-next-line:no-any
public async linkJupyterExtension(jupyter: vscode.Extension<any> | undefined): Promise<void> {
if (!jupyter) {
return;
}
if (!jupyter.isActive) {
await jupyter.activate();
}
// tslint:disable-next-line:no-unsafe-any
jupyter.exports.registerLanguageProvider(PYTHON.language, new JupyterProvider());
// tslint:disable-next-line:no-unsafe-any
this.documentHasJupyterCodeCells = jupyter.exports.hasCodeCells;
}
private sendLinterRunTelemetry(info: ILinterInfo, resource: vscode.Uri, promise: Promise<ILintMessage[]>, stopWatch: StopWatch, trigger: LinterTrigger): void {
const linterExecutablePathName = info.pathName(resource);
const properties: LintingTelemetry = {
tool: info.id,
hasCustomArgs: info.linterArgs(resource).length > 0,
trigger,
executableSpecified: linterExecutablePathName.length > 0
};
sendTelemetryWhenDone(EventName.LINTING, promise, stopWatch, properties);
}
private isDocumentOpen(uri: vscode.Uri): boolean {
return this.documents.textDocuments.some(document => document.uri.fsPath === uri.fsPath);
}
private createDiagnostics(message: ILintMessage, _document: vscode.TextDocument): vscode.Diagnostic {
const position = new vscode.Position(message.line - 1, message.column);
const range = new vscode.Range(position, position);
const severity = lintSeverityToVSSeverity.get(message.severity!)!;
const diagnostic = new vscode.Diagnostic(range, message.message, severity);
diagnostic.code = message.code;
diagnostic.source = message.provider;
return diagnostic;
}
private async shouldLintDocument(document: vscode.TextDocument): Promise<boolean> {
if (!await this.linterManager.isLintingEnabled(false, document.uri)) {
this.diagnosticCollection.set(document.uri, []);
return false;
}
if (document.languageId !== PYTHON.language) {
return false;
}
const workspaceFolder = this.workspace.getWorkspaceFolder(document.uri);
const workspaceRootPath = (workspaceFolder && typeof workspaceFolder.uri.fsPath === 'string') ? workspaceFolder.uri.fsPath : undefined;
const relativeFileName = typeof workspaceRootPath === 'string' ? path.relative(workspaceRootPath, document.fileName) : document.fileName;
const settings = this.configurationService.getSettings(document.uri);
// { dot: true } is important so dirs like `.venv` will be matched by globs
const ignoreMinmatches = settings.linting.ignorePatterns.map(pattern => new Minimatch(pattern, { dot: true }));
if (ignoreMinmatches.some(matcher => matcher.match(document.fileName) || matcher.match(relativeFileName))) {
return false;
}
if (document.uri.scheme !== 'file' || !document.uri.fsPath) {
return false;
}
return this.fileSystem.fileExists(document.uri.fsPath);
}
}